Fix for enabling results grouping for newly added results webpart

[patrikhellgren]

Fixes an issue that would occur when enabling results grouping in the details list layout for a newly added results webpart. After adding a results webpart and switching to details list layout the grouping toggle was did not change state until you first exited webpart properties and then edited it again.

[wobba]

@patrikhellgren I think some improvement can be made here as your change will always load the grouping part - regardless of being used or not. I think you can maybe move the code to getPropertyPaneFieldsConfiguration, or check if we're in edit or display mode?

[wobba]

@patrikhellgren any opinions on the lazy loading?

[patrikhellgren]

@wobba Sorry, had missed your earlier comment. I will have a look later today. If I remember correctly there is no way of passing the webpart display mode to the layout and there were existing lazy loadings without conditions so that's why it was done that way. I could add the display mode to the layout interface to have a good way of checking that in the layout. Any thoughts on that?

[patrikhellgren]

@wobba I have now checked the code and I remembered correctly, there was already another lazy loading in place without any condition. I agree that it would be optimal if the lazy loading only happened if the webpart was in edit mode. I think the best option would be to add an editMode property to BaseLayout just like BaseDataSource already has and then pass this from the webpart. What is your opinion?

[wobba]

@patrikhellgren I trust your judgement on passing the value :)