Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace refinableyesno token #3998

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

friendbool
Copy link

See SharePoint/sp-dev-docs#9098
When using a YesNo type refiner, the tokens ǂǂ54727565 and ǂǂ46616c7365 do not work. In this case, I replace the tokens with the values true and false. Feel free to modify my code 👋

Copy link

sonarcloud bot commented Sep 19, 2024

@wobba
Copy link
Collaborator

wobba commented Sep 23, 2024

This is interesting indeed and not really expected. Replacing with the strings are an ok workaround for sure. If the same issue also applies to OOB YesNo properties, then I'm wondering if we should rather test on the hex value and not on the property name?

@friendbool
Copy link
Author

Since the issue appears to be related to the refinement of YesNo fields, in SharePoint Online, the only YesNo fields enabled for refinement are those named RefinableYesNoXX. Therefore, we perform a double check: first on the field name and then on the field value. If you believe it would be better to remove the check on the field name, please proceed. Have a good evening, bye.

@wobba wobba changed the base branch from main to develop September 25, 2024 15:05
@wobba
Copy link
Collaborator

wobba commented Sep 25, 2024

There are a few other oob ones, but likely not important. I'll see internally if we can fix this before merging as the issue present on Graph API as well.

@wobba
Copy link
Collaborator

wobba commented Oct 2, 2024

@friendbool can you log this as an API issue on Graph so Microsoft gets a customer reporting it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants