Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using KQl to filter search results in microsoft search #4087

Conversation

akshataggrwal
Copy link

Using KQL to filter search results while using microsoft search instead of aggregation filters.

Issue Reference - #3934

Copy link

sonarcloud bot commented Nov 7, 2024

@wobba
Copy link
Collaborator

wobba commented Nov 8, 2024

I think we should still send as FQL, but add multiple rows with one row per each. At least for the AND clause. And a PR which comments out lines of code is not good.

@wobba
Copy link
Collaborator

wobba commented Nov 9, 2024

Created #4090 which also support dates in KQL. I simplified and use .. for date ranges, which means GE and LT for start and end date. Feel free to test it properly before merging.

@wobba wobba closed this Nov 9, 2024
@akshataggrwal
Copy link
Author

Hi @wobba - Thanks for the updates. I tested the changes in your PR(4090) locally for 'externalItem' entity type and it is working as expected.

Is it reasonable to assume for this to available in next release?

@wobba
Copy link
Collaborator

wobba commented Nov 12, 2024

Thank you for test @akshataggrwal. I'll merge it and get a release going.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants