Running PSScriptAnalyzer as local action. #1388
Open
+112
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mazhelez
reviewed
Jan 10, 2025
mazhelez
reviewed
Jan 10, 2025
mazhelez
reviewed
Jan 10, 2025
mazhelez
reviewed
Jan 10, 2025
… into PSScriptAnalyzerAction
|
@microsoft-github-policy-service agree company="Microsoft" |
aholstrup1
reviewed
Jan 13, 2025
aholstrup1
reviewed
Jan 13, 2025
aholstrup1
previously approved these changes
Jan 14, 2025
mazhelez
previously approved these changes
Jan 14, 2025
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
aholstrup1
previously approved these changes
Jan 16, 2025
mazhelez
reviewed
Jan 17, 2025
aholstrup1
previously approved these changes
Jan 17, 2025
mazhelez
reviewed
Jan 17, 2025
|
|
||
| $htPSA = [ordered]@{ Path = $Path } | ||
| Write-Output "Modules installed, now running tests." | ||
| if (![string]::IsNullOrEmpty($ExcludeRule)) { $htPSA.add('ExcludeRule', $ExcludeRule) } |
There was a problem hiding this comment.
Suggested change
| if (![string]::IsNullOrEmpty($ExcludeRule)) { $htPSA.add('ExcludeRule', $ExcludeRule) } | |
| if ($ExcludeRule) { $htPSA.add('ExcludeRule', $ExcludeRule) } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are currently running PSScriptAnalyzer via the action in this repo: https://github.com/microsoft/psscriptanalyzer-action, however this has more settings and options than we need.
I recreated the action locally, and simplified it to fit our needs.