Adds vehicle name to ros1 camera frame_ids. #4579
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes tf frame_ids of multiple cameras w/ same name distinct.
Fixes: #
Fixes #4578Related PR #4509 (fixes the frame_ids partially)
PR #4478 fixes exactly this behavior but for ROS2. This PR fixes it for ROS1
About
Adds the vehicle name to camera related tf frame_ids. This avoids ambiguous frame_ids, if cameras of multiple
vehicles have the same name.
How Has This Been Tested?
settings.json
Screenshots (if appropriate):
Before - frames img0_optical and img0_body are ambiguous i.e. some drones don't have a transformation to it:
After - every drone now has their own transformations to their respective camera: