Enhance testing: Skip fused_optimizer tests if not supported. #5159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vshekhawat-hlab
requested review from
mrwyattii,
tjruwase and
loadams
as code owners
vshekhawat-hlab
force-pushed
the
vshekhawat/skip_fused_optim_tests
branch
from
c034667
to
a840a7d
Compare
…ccelerator. Added condition check to skip fused_optimizer tests if FusedAdam and FusedLamb are not supported by the accelerator. This enhancement ensures that the tests are appropriately skipped when the hardware configuration does not support these optimizers, preventing potential issues. Details: - Introduced a condition check to determine support for FusedAdam and FusedLamb. - If not supported, fused_optimizer tests are skipped to improve test reliability. - Improved compatibility and stability across different hardware configurations.
vshekhawat-hlab
force-pushed
the
vshekhawat/skip_fused_optim_tests
branch
from
a840a7d
to
050ede6
Compare
Fix the incorrect use of pytest.skip in test_compression.py.
tjruwase
approved these changes
Feb 24, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
loadams
approved these changes
Feb 26, 2024
|
Sorry @vshekhawat-hlab - looks like we have merge conflicts with another PR, could you fix the merge conflicts and we can merge this? Thanks! |
loadams
reviewed
Mar 13, 2024
|
@vshekhawat-hlab - could you resolve the merge conflicts on this PR? |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Can you please check it again. |
sfc-gh-reyazda
pushed a commit
to Snowflake-Labs/DeepSpeed
that referenced
this pull request
Jun 10, 2024
…oft#5159) Enhance testing: Skip fused_optimizer tests if not supported. Added condition check to skip fused_optimizer tests if FusedAdam and FusedLamb are not supported by the accelerator. This enhancement ensures that the tests are appropriately skipped when the hardware configuration does not support these optimizers, preventing potential issues. Details: - Introduced a condition check to determine support for FusedAdam and FusedLamb. - If not supported, fused_optimizer tests are skipped to improve test reliability. - Improved compatibility and stability across different hardware configurations. --------- Co-authored-by: Logan Adams <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance testing: Skip fused_optimizer tests if not supported.
Added condition check to skip fused_optimizer tests if FusedAdam and FusedLamb are not supported by the accelerator. This enhancement ensures that the tests are appropriately skipped when the hardware configuration does not support these optimizers, preventing potential issues.
Details: