Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set shuffle=True by default in data_sampler #6531

Open
wants to merge 45 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
3499202
Set shuffle=True by default in data_sampler
ranzhejiang Sep 13, 2024
eae8ad1
Merge branch 'master' into zhejiang/fix_runtime_dataloader_shuffle
tohtana Sep 17, 2024
fd524d7
Merge branch 'master' into zhejiang/fix_runtime_dataloader_shuffle
loadams Sep 26, 2024
a946e18
Merge branch 'master' into zhejiang/fix_runtime_dataloader_shuffle
tohtana Sep 27, 2024
d40ba2e
Merge branch 'master' into zhejiang/fix_runtime_dataloader_shuffle
loadams Sep 27, 2024
1787888
Merge branch 'master' into zhejiang/fix_runtime_dataloader_shuffle
loadams Sep 27, 2024
ca4e8c8
Merge branch 'master' into zhejiang/fix_runtime_dataloader_shuffle
loadams Sep 27, 2024
360c1d1
Merge branch 'master' into zhejiang/fix_runtime_dataloader_shuffle
loadams Sep 27, 2024
78b4526
Merge branch 'master' into zhejiang/fix_runtime_dataloader_shuffle
loadams Oct 7, 2024
e48f3c9
Merge branch 'master' into zhejiang/fix_runtime_dataloader_shuffle
loadams Oct 8, 2024
232971d
Merge branch 'master' into zhejiang/fix_runtime_dataloader_shuffle
loadams Oct 8, 2024
be2afa9
Merge branch 'master' into zhejiang/fix_runtime_dataloader_shuffle
loadams Oct 8, 2024
c663100
Merge branch 'master' into zhejiang/fix_runtime_dataloader_shuffle
loadams Oct 8, 2024
a2be23e
Merge branch 'master' into zhejiang/fix_runtime_dataloader_shuffle
loadams Oct 9, 2024
a12e124
Merge branch 'master' into zhejiang/fix_runtime_dataloader_shuffle
loadams Oct 9, 2024
c2737e8
Merge branch 'master' into zhejiang/fix_runtime_dataloader_shuffle
loadams Oct 9, 2024
bef97b9
Merge branch 'master' into zhejiang/fix_runtime_dataloader_shuffle
loadams Oct 9, 2024
511db3a
Merge branch 'master' into zhejiang/fix_runtime_dataloader_shuffle
ranzhejiang Oct 10, 2024
e75b0a3
Merge branch 'master' into zhejiang/fix_runtime_dataloader_shuffle
loadams Oct 15, 2024
9da9c7b
Merge branch 'master' into zhejiang/fix_runtime_dataloader_shuffle
tohtana Oct 15, 2024
a6849ec
Merge branch 'master' into zhejiang/fix_runtime_dataloader_shuffle
tohtana Oct 17, 2024
809aa05
Merge branch 'master' into zhejiang/fix_runtime_dataloader_shuffle
loadams Oct 23, 2024
0c2a866
Merge branch 'master' into zhejiang/fix_runtime_dataloader_shuffle
tohtana Oct 24, 2024
cf2a5ad
Merge branch 'master' into zhejiang/fix_runtime_dataloader_shuffle
loadams Oct 25, 2024
23beaac
Merge branch 'master' into zhejiang/fix_runtime_dataloader_shuffle
loadams Oct 28, 2024
aee451b
Merge branch 'master' into zhejiang/fix_runtime_dataloader_shuffle
loadams Oct 28, 2024
dbf6c92
Merge branch 'master' into zhejiang/fix_runtime_dataloader_shuffle
loadams Oct 28, 2024
534cc30
Merge branch 'master' into zhejiang/fix_runtime_dataloader_shuffle
loadams Oct 29, 2024
8cd84de
Merge branch 'master' into zhejiang/fix_runtime_dataloader_shuffle
loadams Oct 29, 2024
f606eb4
Merge branch 'master' into zhejiang/fix_runtime_dataloader_shuffle
loadams Oct 29, 2024
7bced38
Merge branch 'master' into zhejiang/fix_runtime_dataloader_shuffle
loadams Oct 30, 2024
f26386b
Merge branch 'master' into zhejiang/fix_runtime_dataloader_shuffle
loadams Oct 31, 2024
a999ad7
Merge branch 'master' into zhejiang/fix_runtime_dataloader_shuffle
loadams Oct 31, 2024
d8493a0
Merge branch 'master' into zhejiang/fix_runtime_dataloader_shuffle
loadams Oct 31, 2024
4fde866
Merge branch 'master' into zhejiang/fix_runtime_dataloader_shuffle
loadams Nov 1, 2024
21d8697
Merge branch 'master' into zhejiang/fix_runtime_dataloader_shuffle
loadams Nov 4, 2024
f7206db
Merge branch 'master' into zhejiang/fix_runtime_dataloader_shuffle
loadams Nov 4, 2024
c22d414
Merge branch 'master' into zhejiang/fix_runtime_dataloader_shuffle
loadams Nov 4, 2024
376a563
Merge branch 'master' into zhejiang/fix_runtime_dataloader_shuffle
loadams Nov 6, 2024
9352f15
Merge branch 'master' into zhejiang/fix_runtime_dataloader_shuffle
loadams Nov 6, 2024
6f5b51f
Merge branch 'master' into zhejiang/fix_runtime_dataloader_shuffle
loadams Nov 6, 2024
4956b5a
Merge branch 'master' into zhejiang/fix_runtime_dataloader_shuffle
loadams Nov 7, 2024
ef3b32f
Merge branch 'master' into zhejiang/fix_runtime_dataloader_shuffle
loadams Nov 8, 2024
d422717
Merge branch 'master' into zhejiang/fix_runtime_dataloader_shuffle
loadams Nov 11, 2024
4d3aaa5
Merge branch 'master' into zhejiang/fix_runtime_dataloader_shuffle
loadams Nov 12, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion deepspeed/runtime/engine.py
Original file line number Diff line number Diff line change
Expand Up @@ -1782,7 +1782,7 @@ def deepspeed_io(self,
dataset,
num_replicas=data_parallel_world_size,
rank=data_parallel_rank,
shuffle=False,
shuffle=True,
)

deepspeed_dataloader_config = {}
Expand Down
2 changes: 1 addition & 1 deletion deepspeed/runtime/pipe/engine.py
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ def _build_data_iter(self, dataset):
sampler = torch.utils.data.distributed.DistributedSampler(dataset,
num_replicas=self.dp_world_size,
rank=self.mpu.get_data_parallel_rank(),
shuffle=False)
shuffle=True)
# Build a loader and make it repeating.
pipe_dataloader = self.deepspeed_io(dataset, data_sampler=sampler)
pipe_dataloader = RepeatingLoader(pipe_dataloader)
Expand Down
Loading