Skip to content

Commit

Permalink
BugFix: fix code ql for python alert (#665)
Browse files Browse the repository at this point in the history
<!-- Please provide brief information about the PR, what it contains &
its purpose, new behaviors after the change. And let us know here if you
need any help: https://github.com/microsoft/HydraLab/issues/new -->

## Description

![image](https://github.com/user-attachments/assets/77482323-a9d1-4b56-88e3-7be1b8e2958b)

<!-- A few words to explain your changes -->

### Linked GitHub issue ID: #  

## Pull Request Checklist
<!-- Put an x in the boxes that apply. This is simply a reminder of what
we are going to look for before merging your code. -->

- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Code compiles correctly with all tests are passed.
- [x] I've read the [contributing
guide](https://github.com/microsoft/HydraLab/blob/main/CONTRIBUTING.md#making-changes-to-the-code)
and followed the recommended practices.
- [ ] [Wikis](https://github.com/microsoft/HydraLab/wiki) or
[README](https://github.com/microsoft/HydraLab/blob/main/README.md) have
been reviewed and added / updated if needed (for bug fixes / features)

### Does this introduce a breaking change?
*If this introduces a breaking change for Hydra Lab users, please
describe the impact and migration path.*

- [ ] Yes
- [x] No

## How you tested it
*Please make sure the change is tested, you can test it by adding UTs,
do local test and share the screenshots, etc.*


Please check the type of change your PR introduces:
- [x] Bugfix
- [ ] Feature
- [ ] Technical design
- [ ] Build related changes
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Code style update (formatting, renaming) or Documentation content
changes
- [ ] Other (please describe): 

### Feature UI screenshots or Technical design diagrams
*If this is a relatively large or complex change, kick it off by drawing
the tech design with PlantUML and explaining why you chose the solution
you did and what alternatives you considered, etc...*
  • Loading branch information
zhou9584 authored Dec 2, 2024
1 parent e01c685 commit b4d31b2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion hercules/util.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def create_file(path, content):

def filter_functions(class_name, functions):
ret = functions
ret = [s for s in ret if re.match(r"public\s+\w+\s+\w+\((\w+,\s*|\w+\s*)*\)", s)]
ret = [s for s in ret if re.match(r"public\s+\w+\s+\w+\((\w+\s+\w+\s*,\s*)*\w+\s+\w+\s*\)", s)]
ret = [s for s in ret if (class_name + "(") not in s]
return ret

Expand Down

0 comments on commit b4d31b2

Please sign in to comment.