-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] update libboost version from 1.74
to 1.83
#6582
base: master
Are you sure you want to change the base?
Conversation
@@ -104,6 +104,7 @@ list( | |||
"libs/any" | |||
"libs/array" | |||
"libs/assert" | |||
"libs/atomic" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Starting from 1.77
filesystem
module requires atomic
module
https://github.com/boostorg/filesystem/blob/9794725bda2e612f1fdcadd98cdce5b7bfb548f1/CMakeLists.txt#L180
@@ -126,6 +128,7 @@ list( | |||
"libs/lexical_cast" | |||
"libs/math" | |||
"libs/move" | |||
"libs/mp11" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Starting from 1.81
container_hash
module requires describe
and mp11
modules
https://github.com/boostorg/container_hash/blob/bd5b7a359c285a65836674d963e1137b067983ac/CMakeLists.txt#L18-L19
@@ -185,6 +192,7 @@ ExternalProject_Add( | |||
runtime-link=shared | |||
variant=release | |||
threading=multi | |||
address-model=${BOOST_ADDRESS_MODEL} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To fix the following error on Windows:
CUSTOMBUILD : error : Name clash for '<pC:\Users\VssAdministrator\tmp\tmpgmzb0fzs\build\Boost\source\stage\lib>libboost_chrono-vc142-mt-1_83.lib' [C:\Users\VssAdministrator\tmp\tmpgmzb0fzs\build\Boost.vcxproj]
CUSTOMBUILD : error : [C:\Users\VssAdministrator\tmp\tmpgmzb0fzs\build\Boost.vcxproj]
CUSTOMBUILD : error : Tried to build the target twice, with property sets having [C:\Users\VssAdministrator\tmp\tmpgmzb0fzs\build\Boost.vcxproj]
CUSTOMBUILD : error : these incompatible properties: [C:\Users\VssAdministrator\tmp\tmpgmzb0fzs\build\Boost.vcxproj]
CUSTOMBUILD : error : [C:\Users\VssAdministrator\tmp\tmpgmzb0fzs\build\Boost.vcxproj]
CUSTOMBUILD : error : - <address-model>32 [C:\Users\VssAdministrator\tmp\tmpgmzb0fzs\build\Boost.vcxproj]
CUSTOMBUILD : error : - <address-model>64 [C:\Users\VssAdministrator\tmp\tmpgmzb0fzs\build\Boost.vcxproj]
CUSTOMBUILD : error : [C:\Users\VssAdministrator\tmp\tmpgmzb0fzs\build\Boost.vcxproj]
CUSTOMBUILD : error : Please make sure to have consistent requirements for these [C:\Users\VssAdministrator\tmp\tmpgmzb0fzs\build\Boost.vcxproj]
CUSTOMBUILD : error : properties everywhere in your project, especially for install [C:\Users\VssAdministrator\tmp\tmpgmzb0fzs\build\Boost.vcxproj]
CUSTOMBUILD : error : targets. [C:\Users\VssAdministrator\tmp\tmpgmzb0fzs\build\Boost.vcxproj]
@jameslamb Seems that I'm stuck here with Windows. Everything is OK with Linux, but for Windows the following error is raised:
Maybe you have any ideas about why I believe this is closely related to the following boost refactoring: boostorg/build@boost-1.75.0...boost-1.76.0 |
hmmmm I'm very unsure, but maybe these have some hints? I found those looking around for mentions of |
Unfortunately, still no support for MSVC 2022
LightGBM/cmake/IntegratedOpenCL.cmake
Lines 62 to 64 in b8241fd
https://www.boost.org/doc/libs/1_83_0/tools/build/doc/html/index.html#bbv2.reference.tools.compiler.msvc
boostorg/boost#914