Merge pull request #220 from microsoft/pete-dev

Significant console performance updates
microsoft · Jan 16, 2024 · 556c7e8 · 556c7e8
2 parents b56dd59 + 5a40b48
commit 556c7e8
Show file tree

Hide file tree

Showing 5 changed files with 269 additions and 110 deletions.
diff --git a/build/staging/version/BundleInfo.wxi b/build/staging/version/BundleInfo.wxi
@@ -1,4 +1,4 @@
 <Include>
   <?define SetupVersionName="Developer Preview 4" ?>
-  <?define SetupVersionNumber="1.0.24014.2122" ?>
+  <?define SetupVersionNumber="1.0.24015.1748" ?>
 </Include>
diff --git a/src/api/Abstraction/MidiSrvAbstraction/Midi2.MidiSrv.cpp b/src/api/Abstraction/MidiSrvAbstraction/Midi2.MidiSrv.cpp
@@ -21,7 +21,7 @@ CMidi2MidiSrv::Initialize(
         TraceLoggingPointer(this, "this")
         );
 
-    MIDISRV_CLIENTCREATION_PARAMS creationParams{ 0 };
+    MIDISRV_CLIENTCREATION_PARAMS creationParams{ };
     PMIDISRV_CLIENT client{ nullptr };
     wil::unique_rpc_binding bindingHandle;
 
@@ -48,8 +48,13 @@ CMidi2MidiSrv::Initialize(
 
     creationParams.Flow = Flow;
     creationParams.DataFormat = CreationParams->DataFormat;
+
     // Todo: client side buffering requests to come from some service setting?
+    // - See https://github.com/microsoft/MIDI/issues/219 for details
+
     creationParams.BufferSize = PAGE_SIZE;
+    //creationParams.BufferSize = 512;    // Set this for debugging see https://github.com/microsoft/MIDI/issues/182 for all the drama :)
+
 
     RETURN_IF_FAILED(GetMidiSrvBindingHandle(&bindingHandle));
 

diff --git a/src/api/Libs/MidiKs/MidiKs.cpp b/src/api/Libs/MidiKs/MidiKs.cpp
@@ -156,6 +156,7 @@ KSMidiDevice::PinSetState(
     return S_OK;
 }
 
+_Use_decl_annotations_
 HRESULT
 KSMidiDevice::ConfigureLoopedBuffer(ULONG& BufferSize
 )