Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default SlnGenProjectName for Traversal projects #559

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MattKotsenas
Copy link
Member

microsoft/slngen#557 added support for customizing the solution name using the MSBuild property <SlnGenProjectName>.

Today, if a user runs SlnGen with default properties, every VS window will unhelpfully be named "dirs". With this change, if a user hasn't set this property, this change sets it to the parent directory name, which is usually more descriptive. In some cases that may result in equally unhelpful names like "src", but that's no worse than today.

This may be considered a breaking change for SlnGen users in some scenarios. Specifically, if they were running slngen with no parameters set and then assuming the resulting solution would be named {dirs}.sln. In many cases, anyone that's writing scripts with slngen is also setting -o|--solutionfile, so they wouldn't be impacted, but I'm sure someone is relying on the name.

@MattKotsenas
Copy link
Member Author

Open to thoughts / considerations on the benefits / risks here, but wanted to open a PR to start the conversation :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant