-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XS⚠️ ◾ Repo Enhancements #509
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
PR Metrics✔ Thanks for keeping your pull request small.
Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs! |
omex-github-bot-external
changed the title
XS✔ ◾ Repo Enhancements
XS⚠️ ◾ Repo Enhancements
Jun 6, 2024
omex-github-bot-external
changed the title
XS✔ ◾ Repo Enhancements
XS⚠️ ◾ Repo Enhancements
Jun 6, 2024
omex-github-bot-external
changed the title
XS✔ ◾ Repo Enhancements
XS⚠️ ◾ Repo Enhancements
Jun 6, 2024
omex-github-bot-external
changed the title
XS✔ ◾ Repo Enhancements
XS⚠️ ◾ Repo Enhancements
Jun 6, 2024
omex-github-bot-external
changed the title
XS✔ ◾ Repo Enhancements
XS⚠️ ◾ Repo Enhancements
Jun 6, 2024
omex-github-bot-external
changed the title
XS✔ ◾ Repo Enhancements
XS⚠️ ◾ Repo Enhancements
Jun 6, 2024
omex-github-bot-external
changed the title
XS✔ ◾ Repo Enhancements
XS⚠️ ◾ Repo Enhancements
Jun 6, 2024
omex-github-bot-external
changed the title
XS✔ ◾ Repo Enhancements
XS⚠️ ◾ Repo Enhancements
Jun 6, 2024
K-Cully
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This changes the project's configuration files and build scripts. The most significant changes include the addition of hardening steps to the GitHub Actions workflows, updates to Node.js and npm commands, and modifications to file paths and URLs.
GitHub Actions Workflow Updates:
Harden Runner
steps have been added to all jobs in the.github/workflows/build.yml
,.github/workflows/release-phase-1-internal.yml
,.github/workflows/release-phase-2.yml
, and.github/workflows/support/release-phase-1-comment.md
files. These steps use thestep-security/harden-runner
action to improve the security of the runner environment. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]Node.js and npm Command Updates:
npm install
commands have been replaced withnpm ci
for more reliable dependency installations. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]npm-check-updates
package has been added to the project's dependencies.File Path and URL Modifications:
indent_size
setting for theLICENSE.txt
file has been moved to thesrc/LICENSE.txt
file in the.editorconfig
file.README.md
anddocs/development.md
files have been updated to their correct versions. [1] [2]LICENSE.txt
reference in theREADME.md
file has been updated toLICENSE
so that it will be picked up by GitHub.npm install -g tfx-cli
step has been removed from the.github/workflows/build.yml
and.github/workflows/release-phase-2.yml
files. Thetfx-cli
command is now run withnpx
. [1] [2]npm install -g npm-check-updates
step has been removed from the.github/workflows/release-phase-1-internal.yml
file. Thencu -u
command is now run withnpx
.npm install && mkdirp $npm_config_dir && ncp src $npm_config_dir
command in thebuild:initialization
script in thepackage.json
file has been updated to usenpm ci
instead ofnpm install
.reflect-metadata
library in thesrc/LICENSE.txt
file has been added.