Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S✔ ◾ Adding support for Workload Identity Federation #513

Merged

Conversation

muiriswoulfe
Copy link
Member

Summary

This adds support for Workload Identity Federation, including instructions on how it can be established. It also includes an update to support binary files, which were found to be problematic during testing of this PR.

Detailed Description

This introduces several changes to improve the security and documentation of the project. The most significant changes include the addition of Workload Identity Federation as an alternative to Personal Access Tokens (PATs) for authentication, updates to the LICENSE file, and modifications to the documentation.

Authentication improvements:

License updates:

  • LICENSE: Changed the license header from "PR Metrics" to "MIT License".

Documentation updates:

  • .github/linters/markdown-link-check.json: Added a new link to the markdown link checker.
  • README.md: Updated the instructions for setting up a Personal Access Token (PAT).
  • docs/azure-pipelines-task.md: Made several changes to improve the documentation on setting up the Azure Pipelines task, including recommending the use of Workload Identity Federation for authentication and updating the instructions for setting up a PAT. [1] [2] [3] [4] [5]
  • docs/workload-identity-federation.md: Added a new document providing comprehensive instructions on setting up Workload Identity Federation for authentication.
  • src/overview.md: Updated the documentation to include references to the new Workload Identity Federation setup instructions and made other minor updates. [1] [2] [3]

Testing

Test Types

  • Unit tests
  • Manual tests

Unit Test Coverage

100%

@muiriswoulfe muiriswoulfe added the enhancement New feature or request label Jun 17, 2024
@muiriswoulfe muiriswoulfe self-assigned this Jun 17, 2024
@muiriswoulfe muiriswoulfe requested a review from a team as a code owner June 17, 2024 10:17
Copy link
Contributor

github-actions bot commented Jun 17, 2024

PR Metrics

Thanks for keeping your pull request small.
Thanks for adding tests.

Lines
Product Code 399
Test Code 918
Subtotal 1,317
Ignored Code 226
Total 1,543

Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!

@github-actions github-actions bot changed the title Adding support for Workload Identity Federation S✔ ◾ Adding support for Workload Identity Federation Jun 17, 2024
@microsoft microsoft deleted a comment from github-actions bot Jun 17, 2024
@microsoft microsoft deleted a comment from github-actions bot Jun 17, 2024
@muiriswoulfe muiriswoulfe enabled auto-merge (squash) June 17, 2024 15:24
@muiriswoulfe muiriswoulfe merged commit 46dfc32 into main Jun 17, 2024
27 checks passed
@muiriswoulfe muiriswoulfe deleted the muiriswoulfe/workload-identity-federation-minimized branch June 17, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants