Support for Set-GitHubContent to Upload binary files

[StanleyGoldman]

Description

As mentioned in #335, this pull request adds functionality to upload binary content with Set-GitHubContent
#336 got closed to due inactivity. Apologies. I'm still very interested in getting this code merged.

Issues Fixed

Fixes #335

References

Checklist

• You actually ran the code that you just wrote, especially if you did just "one last quick change".
• Comment-based help added/updated, including examples.
• Static analysis is reporting back clean.
• New/changed code adheres to our coding guidelines.
• Formatters were created for any new types being added.
• New/changed code continues to support the pipeline.
• Changes to the manifest file follow the manifest guidance.
• Unit tests were added/updated and are all passing. See testing guidelines. This includes making sure that all pipeline input variations have been covered.
• Relevant usage examples have been added/updated in USAGE.md.
• If desired, ensure your name is added to our Contributors list

[HowardWolosky]

Thanks @StanleyGoldman -- I have this queued for review this week.

[HowardWolosky]

Getting close -- thanks for reviving this change. Looking forward to getting it merged in.

[ghost]

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 14 days of this comment.

[ghost]

This pull request has been automatically closed due to a lack of activity from the author. We understand. Life happens and other things likely came up. We would still love to see your contribution get merged in. Now that it has been closed, a different community member may wish to pick up where you left off. If so, they should speak up by commenting below. If you're still interested in completing this yourself, just respond back and let us know.

[StanleyGoldman]

Heya, I'd still love to get this change in.

[HowardWolosky]

Heya, I'd still love to get this change in.

That's great news. I'm re-opening the PR. Your next step is to address the PR feedback and to resolve the merge conflicts.

[StanleyGoldman]

@HowardWolosky ready when you are.

[HowardWolosky]

Thanks for the update.
Looks like you still have a few more changes to make, primarily in the tests (were those successfully running locally for you?)

[HowardWolosky]

Small bit of a additional feedback. Thanks for the effort here, and apologies for delay in review.

[HowardWolosky]

/azp run PowerShellForGitHub-CI

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[HowardWolosky]

/azp run PowerShellForGitHub-CI

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[HowardWolosky]

/azp run PowerShellForGitHub-CI

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[HowardWolosky]

/azp run PowerShellForGitHub-CI

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[HowardWolosky]

Apologies for taking so long to finally review this update.
The product change looks good.
On the test side, the first test is also good.
The only concern that I have is that it looks like you intended for your second test to be dependent on the first test (in that you're hoping to validate that you can overwrite existing content that was written by the previous test. The issue of that is that each of these Contexts should be able to run independently. If you want a context that is testing overwriting existing content, then you should have that happen within the scope of a single Context.

Ideally we should be able to repro a test bug by running just the failing test, which wouldn't be possible if the failure only repro'd if something needed to happen in a separate context first.

[microsoft-github-policy-service]

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 14 days of this comment.

[microsoft-github-policy-service]

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 14 days of this comment.

[microsoft-github-policy-service]

This pull request has been automatically closed due to a lack of activity from the author. We understand. Life happens and other things likely came up. We would still love to see your contribution get merged in. Now that it has been closed, a different community member may wish to pick up where you left off. If so, they should speak up by commenting below. If you're still interested in completing this yourself, just respond back and let us know.