This repository has been archived by the owner on Jan 12, 2024. It is now read-only.
Remove NumSharp dependency #644
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billti
reviewed
Dec 5, 2022
| @@ -54,6 +51,8 @@ public void DumpSReturnsCorrectMatrix() | |||
| Assert.Equal(0.0, (double)unitary.Data[0, 1, 1], precision: 6); | |||
| Assert.Equal(0.0, (double)unitary.Data[1, 0, 1], precision: 6); | |||
| Assert.Equal(1.0, (double)unitary.Data[1, 1, 1], precision: 6); | |||
|
|
|||
| Assert.Equal("Real:\n[[1.0000000000000002, 0], \n[0, 0]]\nImag:\n[[0, 0], \n[0, 1.0000000000000002]]", unitary.ToString()); | |||
There was a problem hiding this comment.
Why are the array dimensions different between implementations?
There was a problem hiding this comment.
The previous implementation uses a 3 dimensional matrix of floating-point values to represent a two-dimensional matrix of complex numbers (the extra dimension is used to represent the real and imaginary parts of the values).
The new implementation uses a two dimensional matrix of complex values (internally it uses a one-dimensional list to store everything).
billti
approved these changes
Dec 6, 2022
|
/azp where |
|
Azure DevOps orgs getting events for this repository: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors some code that deals with unitary matrix to drop the NumSharp dependency.