Add readable byte streams #1362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
MattiasBuelens
commented
Jul 19, 2022
MattiasBuelens
commented
Jul 20, 2022
saschanaz
reviewed
Aug 1, 2022
Co-authored-by: Kagami Sascha Rosylight <[email protected]>
saschanaz
reviewed
Aug 4, 2022
| controller.enqueue("b"); | ||
| controller.close(); | ||
| }, | ||
| cancel(reason) { | ||
| assertType<any>(reason); |
There was a problem hiding this comment.
Does this really do anything? 😄 (But probably good to be explicit)
|
LGTM |
|
Merging because @saschanaz is a code-owner of all the changes - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Firefox 102 adding support for readable byte streams, we now have two browser engines (Chromium and Gecko) shipping this feature. This means we can finally add official type definitions! 😁
Most of work was already done in #890 but then those types had to be removed. This PR brings them back, and hopefully they'll stay this time around. 😅