Add Ed25519 overload for SubtleCrypto#generateKey
#1594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
|
Maybe we should have KeyUsagesMap for other algorithms too? |
saschanaz
reviewed
Jul 12, 2023
inputfiles/overridingTypes.jsonc
Outdated
| @@ -1589,6 +1589,7 @@ | |||
| "generateKey": { | |||
| "name": "generateKey", | |||
| "additionalSignatures": [ | |||
| "generateKey(algorithm: \"Ed25519\", extractable: boolean, keyUsages: ReadonlyArray<Extract<KeyUsage, \"sign\" | \"verify\">>): Promise<CryptoKeyPair>", | |||
There was a problem hiding this comment.
Isn't Extract<KeyUsage, "sign" | "verify"> effectively just "sign" | "verify"? Maybe the latter can be concise.
|
LGTM per:
But this is Ed25519 specific, we should generalize this for other algorithms. |
|
Merging because @saschanaz is a code-owner of all the changes - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find myself constantly having to do this:
This PR updates the types so as to indicate that this method always returns a keypair for the algorithm
Ed25519. It further constrains the type of theKeyUsagesto justsignandverify– the only ones allowed by the spec.