Remove bcrypt-nodejs in favor of bcrypt. Closes #244

[davl3232]

This PR replaces bcrypt-nodejs to bcrypt, since, as discussed in #244, the later is a better maintained version and uses the same API.

• Updated an import and one call to bcrypt.hash() at models/User.ts.
• Updated README.md references to bcrypt-nodejs.
• Aligned a table in README.md.

[msftclas]

All CLA requirements met.

[peterblazejewicz]

LGTM
Reviewed and run locally (mac OS)

[peterblazejewicz]

Hey @davl3232
Thanks for the change. Could you redact the PR message, for future reference? Appreciated!

[davl3232]

I just did. Does that work?

[peterblazejewicz]

Yup!

[davl3232]

I found an issue with this new library. It has native dependencies, so it fails on some platforms and NodeJS versions. Sorry for the bother, I'll test one that works with pure Javascript first.

[peterblazejewicz]

so it fails on some platforms and NodeJS versions

Can you post the scenario?
Thanks!

[davl3232]

It failed for me building on a docker instance derived from https://hub.docker.com/_/node/ node:12-alpine

Here's my Dockerfile

FROM node:12-alpine

WORKDIR /usr/app

COPY package.json .

RUN npm i --quiet

COPY . .

ENV NODE_ENV=production

RUN npm run build

RUN npm i -g pm2 --quiet

EXPOSE 8082

CMD ["pm2-runtime", "dist/server.js"]

[davl3232]

There's a bunch of issues on the repo like this one. kelektiv/node.bcrypt.js#759

It fails during npm install:

> [email protected] install /usr/app/node_modules/bcrypt
> node-pre-gyp install --fallback-to-build

node-pre-gyp WARN Using request for node-pre-gyp https download 
node-pre-gyp WARN Tried to download(404): https://github.com/kelektiv/node.bcrypt.js/releases/download/v3.0.6/bcrypt_lib-v3.0.6-node-v72-linux-x64-musl.tar.gz 
node-pre-gyp WARN Pre-built binaries not found for [email protected] and [email protected] (node-v72 ABI, musl) (falling back to source compile with node-gyp) 
gyp ERR! find Python 

It attempts a download a prebuilt binary for each platform + node version, if the platform is not known, then it tries to build the binary. In my docker instance it fails due alpine linux not having a python interpreter.

[peterblazejewicz]

Thanks!