Fix decorator emit crash #60224
Merged
Fix decorator emit crash #60224
+105
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wnleveling stage 3 decorators
typescript-bot
added
Author: Team
For Milestone Bug
jakebailey
reviewed
Oct 14, 2024
| const decorators = getDecorators(node); | ||
| const parameters = getDecoratorsOfParameters(getFirstConstructorWithBody(node)); | ||
| const parameters = useLegacyDecorators ? getDecoratorsOfParameters(getFirstConstructorWithBody(node)) : undefined; |
There was a problem hiding this comment.
Should getDecoratorsOfParameters take the parameter and return undefined instead of copying the ternary to all call sites?
There was a problem hiding this comment.
Branching is cheaper at runtime than invocation, so probably not.
There was a problem hiding this comment.
Maybe a bit overoptimized but alright.
There was a problem hiding this comment.
In this case specifically, just passing the argument to getDecoratorsOfParameters means iterating over all class elements to find a constructor, which is unnecessary work.
jakebailey
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a crash when transforming Stage 3 decorators when both class element decorators and class constructor parameter decorators are present.
Fixes #58269