Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a literal string for ArrayBuffer's toStringTag #60227

Closed
wants to merge 1 commit into from

Conversation

rbuckton
Copy link
Member

Now that all of the typed arrays are generic over buffer, we should be able to use a more specific type for ArrayBuffer's [Symbol.toStringTag] property.

Fixes #60149

@typescript-bot typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Oct 14, 2024
@rbuckton
Copy link
Member Author

@typescript-bot run dt
@typescript-bot test top400
@typescript-bot test tsserver top100
@typescript-bot user test this
@typescript-bot user test tsserver

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 14, 2024

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
run dt ✅ Started 👀 Results
test top400 ✅ Started
test tsserver top100 ✅ Started
user test this ✅ Started
user test tsserver ✅ Started ✅ Results

@jakebailey
Copy link
Member

I think this is a dupe of #60150?

@rbuckton
Copy link
Member Author

Ah, missed that, thanks

@rbuckton rbuckton closed this Oct 14, 2024
@typescript-bot
Copy link
Collaborator

@rbuckton Here are the results of running the user tests with tsserver comparing main and refs/pull/60227/merge:

There were infrastructure failures potentially unrelated to your change:

  • 1 instance of "Unknown failure"

Otherwise...

Everything looks good!

@typescript-bot
Copy link
Collaborator

Hey @rbuckton, the results of running the DT tests are ready.

There were interesting changes:

Changes are too big to display here, please check the log.

You can check the log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Use string literal type in ArrayBuffer's Symbol.toStringTag
3 participants