Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Some xaml substitution[WIP] #1563

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix: Some xaml substitution[WIP] #1563

wants to merge 2 commits into from
+10 −6

Conversation

HO-COOH
Copy link
Contributor

@HO-COOH HO-COOH commented Jun 14, 2024

Description

Some xaml code substitutions are not working. This pr tries to fix them all.

Motivation and Context

It's confusing and someone would have to go to source code to find out the actual code.

How Has This Been Tested?

Manual.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

marcelwgn
marcelwgn reviewed Jun 21, 2024
View reviewed changes
Copy link
Contributor

@marcelwgn marcelwgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for looking into XAML substitutions not working, excited to get this fixed!

WinUIGallery/ControlPages/EasingFunctionPage.xaml Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelwgn marcelwgn marcelwgn left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HO-COOH @marcelwgn