-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show item base classes #1591
Show item base classes #1591
Conversation
Thanks for the PR, this is an awesome addition! I think the breadcrumb bar should be below the header, since it's not for navigating and purely for informative purposes. @niels9001 |
Oooh I like this.. agree with @karkarl that having it below the title makes more sense. That being said, I think the page header is starting to become pretty info heavy. I wonder if the inheritance and namespace should live under a button+flyout? It's relevant information, but also not critical information. Thoughts @AndrewKeepCoding @karkarl ? |
@karkarl Thanks for the feedback. |
@niels9001 I agree. There's a lot of text around there. But IMHO, I thought it'd be better for devs, especially the new ones in WinUI, that this inheritance info just gets into their eyes. |
I might be an outlier with this position, but I don't think new devs really need to have that information often. There are very few situations where one wouldn't derive from UserControl/Control (which the new control templates already do). Out of curiosity, in which situation would this information would have been helpful to you @AndrewKeepCoding? 😃 |
@marcelwgn Might sound stupid and maybe it's just me, but for example, I remember I was assuming that That's why I thought this feature would be good for devs new to WinUI. I totally understand your opinions guys. Let me know if you want to close this or modify it to a less texty way. 🙂 |
I think that looks great! Can you push the commit? |
@karkarl Done. |
/azp run |
Description
Shows the base classes of each control/element.
Motivation and Context
This will help devs understand the inheritance structure of WinUI controls/elements.
How Has This Been Tested?
Tested on VS.
Screenshots (if appropriate):
Types of changes