feat: update samples to use 0.3.0 windows-drivers-rs crates #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmmc88
changed the title
|
@NateD-MSFT I finished this pr with the last couple of changes needed since 0.3.0 crates are out. please review :) |
wmmc88
reviewed
Oct 4, 2024
NateD-MSFT
commented
Oct 4, 2024
There was a problem hiding this comment.
@wmmc88 I can't formally mark approved since I started this PR (and I think because I committed your most recent suggestion) but LGTM.
wmmc88
force-pushed
the
new-makefile-change
branch
from
b71fff2 to
31b4f0c
Compare
wmmc88
approved these changes
Oct 5, 2024
svasista-ms
approved these changes
Oct 21, 2024
|
[celebrate] Shravan Vasista reacted to your message:
…________________________________
From: NateD-MSFT ***@***.***>
Sent: Monday, October 21, 2024 7:34:39 PM
To: microsoft/Windows-rust-driver-samples ***@***.***>
Cc: Shravan Vasista ***@***.***>; Review requested ***@***.***>
Subject: Re: [microsoft/Windows-rust-driver-samples] feat: update samples to use 0.3.0 windows-drivers-rs crates (PR #18)
Merged #18<#18> into main.
—
Reply to this email directly, view it on GitHub<#18 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BJKSQE567MESZOFGZ3GWUTTZ4VJM7AVCNFSM6AAAAABIRMLBGSVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUG43TAMZSGY2DQMI>.
You are receiving this because your review was requested.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update this repo to use an upcoming 0.3.0 release of windows-drivers-rs, including the changes from microsoft/windows-drivers-rs#143.
This of course does not build today, but was validated with local changes.