Update camera.js #1239
Draft
Update camera.js #1239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added reset media stream properties before preview to avoid crash when sharing from MJPG stream
kasumman
approved these changes
Aug 21, 2020
|
Note that the javascript samples are archived and are not being maintained. |
Need to update it since OEM are using it. |
Added showErrorMessage function to pop up error message dialog when media capture failed (in most cases camera is being used by another app) to avoid exception caused crash of the app.
|
I left the as archived instead of just deleting them outright. There is no intention of servicing them. Should I delete them? |
I know it is archived and not maintained but one of our partners used the sample JS code to develop their product and found some issues so I need to update it. Could we just have the changes and leave it here? |
gifhuppp
approved these changes
Jul 13, 2021
kowaliew85
approved these changes
Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added reset media stream properties before preview to avoid crash when sharing from MJPG stream
@saredd @chrilaMSFT @kasumman