BluetoothLE: Bugfix for removing the notification/indication handler #1381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix to properly release characteristic notification/indication handlers upon unsubscribing.
Description
Name of sample: BluetoothLE
Previous behavior was to receive duplicate characteristic packets proportional to the number of times the characteristic had been subscribed/unsubscribed w/in a given app launch.
Testing
Added code to store packets received from the peripheral. Configured the peripheral to send the value of a counter which updates every second. Verified that duplicate packets are captured with every user Subscribe/Unsubscribe action. e.g. upon enabling subscribe for a given characteristic three times, I receive 3 packets with the same content.
Type of change
Supported platforms
Minimum OS version: (example: 18362)
Supported languages
Additional remarks
None