Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated README with new logo #4920

Merged
merged 30 commits into from
Jan 14, 2025
Merged

Updated README with new logo #4920

merged 30 commits into from
Jan 14, 2025

Conversation

0x5bfa
Copy link
Contributor

@0x5bfa 0x5bfa commented Nov 27, 2024

Check here for the preview https://github.com/0x5bfa/WindowsAppSDK/tree/5bfa/GH-ReadMe

This PR:

  • Aligns the look and feel of the WASDK, WinUI and WinUI Gallery repos
  • Adds the new WindowsAppSDK logo

@niels9001
Copy link
Contributor

@0x5bfa Love this! Great to bring consistency across the different WinUI/WASDK repo's.

I was looking at this last week myself: https://github.com/niels9001/WindowsAppSDK

Since we now have an official WASDK logo, you might want to copy the assets from my PR?

@0x5bfa
Copy link
Contributor Author

0x5bfa commented Nov 27, 2024

Oh didn't notice, for sure. I'll leave to you!
I tried to make it look better in my pr.

@0x5bfa 0x5bfa closed this Nov 27, 2024
@0x5bfa 0x5bfa deleted the 5bfa/GH-ReadMe branch November 27, 2024 15:26
@0x5bfa 0x5bfa restored the 5bfa/GH-ReadMe branch November 28, 2024 09:53
@0x5bfa 0x5bfa reopened this Nov 28, 2024
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
0x5bfa and others added 12 commits November 28, 2024 22:58
Co-authored-by: Niels Laute <[email protected]>
Co-authored-by: Niels Laute <[email protected]>
Co-authored-by: Niels Laute <[email protected]>
Co-authored-by: Niels Laute <[email protected]>
Co-authored-by: Niels Laute <[email protected]>
Co-authored-by: Niels Laute <[email protected]>
Co-authored-by: Niels Laute <[email protected]>
Co-authored-by: Niels Laute <[email protected]>
Co-authored-by: Niels Laute <[email protected]>
Co-authored-by: Niels Laute <[email protected]>
Co-authored-by: Niels Laute <[email protected]>
Co-authored-by: Niels Laute <[email protected]>
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
0x5bfa and others added 2 commits November 29, 2024 00:44
Copy link
Contributor

@niels9001 niels9001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

README.md Outdated Show resolved Hide resolved
0x5bfa and others added 2 commits November 29, 2024 04:11
@0x5bfa
Copy link
Contributor Author

0x5bfa commented Dec 26, 2024

So what blocks this pr, I don't see any reason?

@mklemarczyk
Copy link

Dont say we wait for "TransportPackage-Foundation-PR" where only docs files are changed ?

dev/MRTCore/README.md Outdated Show resolved Hide resolved
@niels9001 niels9001 changed the title Updated README Updated README with new logo Jan 14, 2025
@codendone codendone merged commit ad53876 into microsoft:main Jan 14, 2025
1 check passed
@0x5bfa 0x5bfa deleted the 5bfa/GH-ReadMe branch January 15, 2025 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants