Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added src for hello-arc-windows #21

Merged
merged 3 commits into from
Feb 8, 2023

Conversation

janegilring
Copy link
Contributor

This pull request contains the following

  • Dockerfile for building Windows Server container image with Node installed, needed as Node does not have an official Windows image per 2023-02-08: Introduce windows images nodejs/docker-node#362
  • Dockerfile for building node application based on the same source files as the existing hello-arc application in this repo (originally based on hello-kubernetes

Signed-off-by: Jan Egil Ring [email protected]

Copy link
Contributor

@likamrat likamrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@likamrat likamrat merged commit 7baa01c into microsoft:main Feb 8, 2023
brauliomsft pushed a commit to brauliomsft/azure-arc-jumpstart-apps that referenced this pull request Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants