Fix step unit test failures in agent pipeline #4134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanduplenskikh
force-pushed
the
users/ivanduplenskikh/tests-failures
branch
4 times, most recently
from
7f3d450 to
5df3638
Compare
ivanduplenskikh
force-pushed
the
users/ivanduplenskikh/tests-failures
branch
from
5df3638 to
f7bf96f
Compare
ivanduplenskikh
force-pushed
the
users/ivanduplenskikh/tests-failures
branch
from
f7bf96f to
55e8aa3
Compare
ivanduplenskikh
force-pushed
the
users/ivanduplenskikh/tests-failures
branch
from
1797acc to
cef92ee
Compare
ivanduplenskikh
force-pushed
the
users/ivanduplenskikh/tests-failures
branch
from
97503e3 to
791a2a2
Compare
DmitriiBobreshev
approved these changes
Jan 18, 2024
merlynomsft
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason:
There is a problem running the ping command through ProcessInvoker.
The invoked process does not catch
Ctrl+C/Ctrl+Breaksignals when we cancel the CancellationToken. This is why the function that cancels the process tree is launched for all processes running in the system, which may take a significant amount of time.Therefore, I replaced the command with one that does not require interactivity, and which will be canceled by the signals built into the agent.