Add secret masking for the telemetry.publish command #4461
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I added the use of the SecretMasker for telemetry.publish command to prevent leaking tokens (including JWT).
By default, the SecretMasker hasn't used cred scan patterns, they could be enabled only using the environment variable.
To use them via a feature flag, I have to move the logic of using the knob from the HostContext to the ExecutionContext and added a runtime source for this knob as well.
P.S. This change must be under the feature flag definitely since I found a comment where it was written that the cred scan could affect the agent performance. But I couldn't confirm this after testing the changes.
Testing:
To test the changes I used the DevFabric environment (Microsoft DevBox).
Testing steps:
Results: