Restore expanded redaction as a default feature. Add a set of new, highly accurate detections. #4466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ghly accurate detections.
added 2 commits
October 12, 2023 15:38
mmrazik
approved these changes
Oct 12, 2023
ivanduplenskikh
approved these changes
Oct 12, 2023
KonstantinTyukalov
approved these changes
Oct 12, 2023
DmitriiBobreshev
approved these changes
Oct 12, 2023
max-zaytsev
reviewed
Oct 12, 2023
src/Microsoft.VisualStudio.Services.Agent/AdditionalMaskingRegexes.CredScan.cs
Outdated
Show resolved
Hide resolved
merlynomsft
approved these changes
Oct 12, 2023
merlynomsft
reviewed
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change replaces previous expanded secret detections with a smaller, tuned set that flags key providers that generate tokens that are easily recognized with few false positives.
We also restore the knob that pulls in the functionality.