Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Node 6 Runner from installation step #4473

Merged
merged 16 commits into from
Jan 23, 2024

Conversation

ismayilov-ismayil
Copy link
Contributor

@ismayilov-ismayil ismayilov-ismayil commented Oct 16, 2023

Due to EOL Node 6 a long time ago, Node 6 runner will be removed from agent installation steps on next releases.
Node 6 runner will be installed if "DisableNode6Tasks" settings 'disabled' (off) on organization level pipeline settings

Copy link
Contributor

@merlynomsft merlynomsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

Copy link
Contributor

@merlynomsft merlynomsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment

src/Misc/externals.sh Outdated Show resolved Hide resolved
src/dev.sh Outdated Show resolved Hide resolved
@merlynomsft merlynomsft dismissed stale reviews from themself November 14, 2023 09:11

revoking review

@ismayilov-ismayil ismayilov-ismayil force-pushed the users/ismayilov-ismayil/remove_node6_runner branch from 23315df to 154315a Compare November 19, 2023 16:05
@ismayilov-ismayil ismayilov-ismayil removed the misc Miscellaneous Changes label Nov 19, 2023
@ismayilov-ismayil ismayilov-ismayil force-pushed the users/ismayilov-ismayil/remove_node6_runner branch from 1d4e1d6 to 764d7de Compare December 9, 2023 23:57
@kirill-ivlev kirill-ivlev merged commit 864c7bb into master Jan 23, 2024
10 checks passed
vmapetr pushed a commit that referenced this pull request Feb 20, 2024
* Redesign node 6 runner installation

* Added Node 6 installer on Agent.Listener

* Update HttpClient handler

* Updated HttpClient handler

* Remove UseNode16 knob

* Rollback Agent.Listener logic

* Update nodejs downloaded fileurl to match linux arch

* Fix missed Darwin-ARM binary

* Add telemetry data about Node 6 installation

---------

Co-authored-by: azure-pipelines-bot <[email protected]>
Co-authored-by: Kirill Ivlev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants