Add SecretMasker implementation to the agent from core package #4495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanduplenskikh
approved these changes
Oct 30, 2023
max-zaytsev
approved these changes
Oct 30, 2023
ismayilov-ismayil
approved these changes
Oct 30, 2023
vmapetr
approved these changes
Oct 30, 2023
merlynomsft
reviewed
Oct 31, 2023
added 2 commits
November 2, 2023 17:07
merlynomsft
reviewed
Nov 2, 2023
merlynomsft
reviewed
Nov 2, 2023
merlynomsft
reviewed
Nov 2, 2023
remove usePerformanceEnhancements since it is used by default in new SecretMasker
merlynomsft
reviewed
Nov 7, 2023
src/Microsoft.VisualStudio.Services.Agent/AdditionalMaskingRegexes.CredScan.cs
Outdated
Show resolved
Hide resolved
merlynomsft
reviewed
Nov 7, 2023
….com/microsoft/azure-pipelines-agent into add_secret_masker_from_core_to_agent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces SecretMasker from vss-core-api package directly inside agent, to have ability to deliver changes faster
Work item: https://dev.azure.com/mseng/AzureDevOps/_workitems/edit/2115952
Testing:
Tested locally that changes works as expected