-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HCIbox - 23h2 support #2367
HCIbox - 23h2 support #2367
Conversation
HCIBox 23h2 merge to feature branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi friend! Thanks you for opening this Pull Request. Someone will review it soon. Thank you for committing to making the Azure Arc Jumpstart better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 👍
I added some comments which should be reviewed before merging.
azure_jumpstart_hcibox/artifacts/PowerShell/Configure-VMManagement.ps1
Outdated
Show resolved
Hide resolved
azure_jumpstart_hcibox/artifacts/PowerShell/Generate-ARM-Template.ps1
Outdated
Show resolved
Hide resolved
azure_jumpstart_hcibox/artifacts/PowerShell/New-HCIBoxCluster.ps1
Outdated
Show resolved
Hide resolved
azure_jumpstart_hcibox/artifacts/PowerShell/New-HCIBoxCluster.ps1
Outdated
Show resolved
Hide resolved
Hcibox23h2 -> segregate AKS and VM vlan/subnets
Hcibox23h2 -> small updates to feature branch
HCIBox decouple dhcp from main function
HCIBox minor aks fixes
HCIBox feature branch - file name changes and remove some unused files
Hcibox23h2 -> small revisions
HCIBox23h2 small fixes
HCIBox23h2 deprecate GetServiceAccountBearerToken.ps1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all documents and files that were submitted to me and I have been working on them all day and have approved them all for the same amount of money as I have received from the previous owners of the property and the property that was listed on the contract with the seller. Also reviewed the contract with the buyers agreement with them to make it look as good to me to get them out of the deal with me. Thank you very much for your patience and understanding🫶🤓❤️
All checked out and approved🌚❤️ |
Adds support for Azure Stack HCI 23H2
Closes #2304