ArcBox 3.0 - Adding a new parameter for the GitHub branch and improving the configuration logic #2652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Egil Ring <[email protected]>
…n the Azure Jumpstart Arcbox artifacts. Update K3sGitOps.ps1 to use the `githubBranch` environment variable when creating the Flux configuration. Update clientVm.bicep and main.bicep to add the `githubBranch` parameter and pass it to the client VM deployment module. Signed-off-by: Jan Egil Ring <[email protected]>
Signed-off-by: Jan Egil Ring <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several updates to the
azure_jumpstart_arcboxproject, mainly focusing on adding a new parameter for the GitHub branch and improving the configuration logic. The most important changes include the addition of thegithubBranchparameter across various scripts and templates, updates to environment variable settings, and enhancements to the VM autologon configuration.Parameter Addition:
azure_jumpstart_arcbox/artifacts/Bootstrap.ps1: AddedgithubBranchparameter to the script parameters and environment variable settings. [1] [2]azure_jumpstart_arcbox/bicep/clientVm/clientVm.bicep: AddedgithubBranchparameter to the Bicep template.azure_jumpstart_arcbox/bicep/main.bicep: Passed thegithubBranchparameter to theclientVmDeploymentmodule.Configuration Updates:
azure_jumpstart_arcbox/artifacts/Bootstrap.ps1: Enhanced VM autologon logic to check if thevmAutologonparameter is explicitly set to "true" and added a message for when autologon is not configured. [1] [2]azure_jumpstart_arcbox/artifacts/gitops_scripts/K3sGitOps.ps1: Updated the GitOps configuration to use the newgithubBranchenvironment variable.Miscellaneous:
azure_jumpstart_arcbox/artifacts/testDefenderForSQL.ps1: Changed the hardcoded password for SQL injection testing.azure_jumpstart_arcbox/bicep/clientVm/clientVm.bicep: Updated thecommandToExecutein the VM bootstrap configuration to include thegithubBranchparameter.