Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConversationAccount non-id fields are optional #6542

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

drmason13
Copy link

This change matches the current written specification, see https://github.com/microsoft/botframework-sdk/blob/main/specs/botframework-activity/botframework-activity.md#conversation

Fixes #6541

Proposed Changes

  • ConversationAccount.name is optional
  • ConversationAccount.isGroup is optional
  • ConversationAccount.conversationType is optional

Testing

@drmason13 drmason13 requested a review from a team as a code owner September 10, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

protocol JSON schema: required fields of ConversationAccount don't match written specification
1 participant