New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: handle disabled lockfile #107

Merged

mxschmitt merged 1 commit into microsoft:main from PierreDemailly:feat/support-disabled-lockfile

Jun 20, 2024

Contributor

PierreDemailly commented Nov 30, 2023

When initializing playwright in an existing project, the CLI miss package-lock=false in the .npmrc (if exists).

npm ci is not compatible without lockfile, this PR fixes it: when package-lock.json is disabled, replaces npm ci with npm i in the workflow.

Contributor Author

PierreDemailly commented Dec 1, 2023

@microsoft-github-policy-service agree


          feat: handle disabled lockfile

eb41434

mxschmitt force-pushed the feat/support-disabled-lockfile branch from 389e99d to eb41434 Compare

June 20, 2024 08:30

mxschmitt approved these changes

View reviewed changes

mxschmitt merged commit b8f6d23 into microsoft:main

7 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet