Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Chrome, Edge, Electron implementations #448

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

4e554c4c
Copy link

@4e554c4c 4e554c4c commented Dec 8, 2023

These repositories are all listed as deprecated. The implementation is now internal to VSCode, and cannot be installed or used by any other editors. This means that its presence in the list is no longer useful.

These repositories are all listed as deprecated. The implementation is
now internal to VSCode, and cannot be installed or used by any other
editors. This means that its presence in the list is no longer useful.
@connor4312
Copy link
Member

I don't see a need to remove them, they're still valid as implementation references.

They also can be installed in other editors, as both are traditional program-based adapters. Though there's no real reason to since the more modern js-debug exists.

@connor4312 connor4312 closed this Dec 8, 2023
@4e554c4c
Copy link
Author

4e554c4c commented Dec 8, 2023

This page is not only useful for implementation references. It states

You may find these useful as reference material when writing your own debug adapter, or for use in your editor of choice.

These entries contain not only source code, but link to plugins which no longer exist.

If they are useful only to understand 'historical' implementations, perhaps they should be moved to a section that says such, and which does not contain usage instructions.

I also do not see any mention of js-debug in this list. Maybe it should be added so that those who don't use VSCode's proprietary marketplace can discover debug-adapter-protocol implementations.

@connor4312
Copy link
Member

js-debug is the JavaScript Debugger that's linked in the table.

Maybe a * or something to indicated deprecated would be good. I think that should be applied only to repos where the owner has archived them.

@connor4312 connor4312 reopened this Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants