Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an optional 'sessionId' parameter to ProtocolMessage #80

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from

Conversation

EricCornelson
Copy link

A first step in enabling a "flat session" mode of communication in the protocol (see #79 for more details).

@weinand weinand self-assigned this Oct 24, 2019
@weinand weinand added the feature-request Request for new features or functionality label Feb 28, 2020
@weinand
Copy link
Contributor

weinand commented Nov 15, 2022

Multiplexing sessions and the concept of a sessionId is not part of the DAP spec.
Having a sessionId as an optional property on the ProtocolMessage is not needed and violates the concept of "Separation of concerns".

If some other entity wants to multiplex sessions over a single communication channel it can do so by wrapping a ProtocolMessage in another structure that has a sessionId property.

@weinand weinand removed their assignment Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants