Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build pydevd binaries before running tests #1722

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Conversation

AdamYoblick
Copy link
Member

We're removing these binaries from the repo and adding a .gitignore entry for them, since we want to build them ourselves. So we need to make sure we build them before running tests, because the attach tests will fail if those binaries don't exist.

@AdamYoblick AdamYoblick requested a review from a team as a code owner November 5, 2024 19:21
Copy link
Contributor

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the path is off? But looks good otherwise. Not sure why the path is off.

@AdamYoblick
Copy link
Member Author

Looks like the path is off? But looks good otherwise. Not sure why the path is off.

Yep i just fixed it. Path is off because the steps were copy pasted from another pipeline with multiple repos being pulled. So there was an extra folder in the other pipeline, not used in this pipeline. 😄

@AdamYoblick AdamYoblick merged commit abf4bb6 into main Nov 5, 2024
22 checks passed
@AdamYoblick AdamYoblick deleted the build_pydevd_binaries branch November 6, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants