Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[inetstack] Add Warning Message on Data Drop for Data Carrying, SYN Segment #1116

Merged
merged 2 commits into from
Jan 9, 2024
Merged

[inetstack] Add Warning Message on Data Drop for Data Carrying, SYN Segment #1116

merged 2 commits into from
Jan 9, 2024

Conversation

ppenna
Copy link
Collaborator

@ppenna ppenna commented Jan 8, 2024

Description

Summary of Changes

  • Added a warn message on data drop for data carrying, SYN segments.
  • Added test case for connection establishment with a data-carrying, SYN segment.

@ppenna ppenna added the bug Something Isn't Working label Jan 8, 2024
@ppenna ppenna requested a review from iyzhang January 8, 2024 13:46
@ppenna ppenna self-assigned this Jan 8, 2024
iyzhang
iyzhang approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@iyzhang iyzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I know we handle data-carrying ACKs but did not know that data-carrying SYNs were allowed (seems like a good opportunity for a denial of service attack ...)

@ppenna ppenna merged commit cb9ec6c into dev Jan 9, 2024
15 checks passed
@ppenna ppenna deleted the bugfix-inetstack-accept branch January 9, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iyzhang iyzhang iyzhang approved these changes

Assignees

@ppenna ppenna

Labels
bug Something Isn't Working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[inetstack] Drop Packets from Non-Accepted Connections
2 participants
@ppenna @iyzhang