Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[runtime] Enhancement: Create into_buf in the MemoryRuntime #1183

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

[runtime] Enhancement: Create into_buf in the MemoryRuntime #1183

wants to merge 4 commits into from

Conversation

carvalhof
Copy link
Collaborator

This PR creates into_buf function to convert demi_sgarray_t to DemiBuffer without clone.

ppenna
ppenna requested changes Mar 13, 2024
View reviewed changes
Copy link
Collaborator

@ppenna ppenna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking merge to be able to run benchmarks.

@ppenna ppenna self-assigned this Mar 13, 2024
@carvalhof carvalhof force-pushed the enhancement-memory-demibuffer branch from db313ad to f73cb79 Compare April 8, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppenna ppenna ppenna requested changes

@iyzhang iyzhang iyzhang approved these changes

Requested changes must be addressed to merge this pull request.

Assignees

@ppenna ppenna

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carvalhof @ppenna @iyzhang