Fix Import Cancellation Flow #4014
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikaelweave
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -31,12 +31,12 @@ | |||
| public class GetImportRequestHandlerTests | |||
| { | |||
| private readonly IMediator _mediator; | |||
| private IQueueClient _queueClient = Substitute.For<IQueueClient>(); | |||
| private IFhirOperationDataStore _fhirOperationDataStore = Substitute.For<IFhirOperationDataStore>(); | |||
Check notice
Code scanning / CodeQL
Missed 'readonly' opportunity Note
src/Microsoft.Health.Fhir.Core/Features/Operations/FhirOperationDataStoreBase.cs
Fixed
Show fixed
Hide fixed
Comment on lines
+139
to
+146
| if (record.FailureDetails == null) | ||
| { | ||
| record.FailureDetails = new JobFailureDetails("Processing job had no results", HttpStatusCode.InternalServerError); | ||
| } | ||
| else | ||
| { | ||
| record.FailureDetails = new JobFailureDetails(record.FailureDetails.FailureReason + "\r\nProcessing job had no results", HttpStatusCode.InternalServerError); | ||
| } |
Check notice
Code scanning / CodeQL
Missed ternary opportunity Note
src/Microsoft.Health.Fhir.SqlServer/Features/Storage/SqlServerFhirOperationDataStore.cs
Fixed
Show fixed
Hide fixed
src/Microsoft.Health.Fhir.SqlServer/Features/Storage/SqlServerFhirOperationDataStore.cs
Fixed
Show fixed
Hide fixed
src/Microsoft.Health.Fhir.SqlServer/Features/Storage/SqlServerFhirOperationDataStore.cs
Fixed
Show fixed
Hide fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes in this PR.
Related issues
Addresses [issue #].
Testing
Describe how this change was tested.
FHIR Team Checklist
Semver Change (docs)
Patch|Skip|Feature|Breaking (reason)