Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(storybook): Bump export to codesandbox #20524

Merged
merged 1 commit into from
Nov 5, 2021

Conversation

ling1726
Copy link
Member

@ling1726 ling1726 commented Nov 5, 2021

Pull request checklist

Description of changes

Picks up change microsoft/fluentui-storybook-addons#11 which is a
temporary workaround for microsoft/fluentui-storybook-addons#12

Focus areas to test

(optional)

@ling1726 ling1726 requested a review from a team as a code owner November 5, 2021 15:17
@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 5, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit fa4b402:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Nov 5, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: ed9dfd8e9ba2b0920f6c4bc396204b4ced4cacb2 (build)

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-accordion
Accordion (including children components)
56.753 kB
17.873 kB
react-avatar
Avatar
54.097 kB
15.331 kB
react-badge
Badge
22.394 kB
6.707 kB
react-badge
CounterBadge
24.773 kB
7.387 kB
react-badge
PresenceBadge
29.768 kB
8.517 kB
react-button
Button
24.651 kB
7.462 kB
react-button
CompoundButton
29.939 kB
8.418 kB
react-button
MenuButton
27.046 kB
8.227 kB
react-button
SplitButton
33.261 kB
9.328 kB
react-button
ToggleButton
33.78 kB
8.065 kB
react-card
Card - All
48.534 kB
14.421 kB
react-card
Card
43.954 kB
13.196 kB
react-card
CardFooter
7.418 kB
3.182 kB
react-card
CardHeader
8.778 kB
3.64 kB
react-card
CardPreview
7.682 kB
3.341 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
166.267 kB
47.598 kB
react-components
react-components: FluentProvider & webLightTheme
31.058 kB
10.346 kB
react-divider
Divider
14.828 kB
5.375 kB
react-image
Image
9.041 kB
3.734 kB
react-input
Input
13.83 kB
4.958 kB
react-label
Label
8.177 kB
3.445 kB
react-link
Link
10.883 kB
4.449 kB
react-make-styles
makeStaticStyles (runtime)
7.59 kB
3.322 kB
react-make-styles
makeStyles + mergeClasses (runtime)
22.238 kB
8.411 kB
react-make-styles
makeStyles + mergeClasses (build time)
2.561 kB
1.206 kB
react-menu
Menu (including children components)
103.644 kB
31.979 kB
react-menu
Menu (including selectable components)
106.032 kB
32.349 kB
react-popover
Popover
99.149 kB
30.108 kB
react-portal
Portal
6.621 kB
2.226 kB
react-positioning
usePopper
22.808 kB
7.935 kB
react-provider
FluentProvider
14.056 kB
5.267 kB
react-slider
RangedSlider
39.807 kB
11.454 kB
react-slider
Slider
33.204 kB
10.302 kB
react-switch
Switch
25.311 kB
8.143 kB
react-text
Text - Default
10.603 kB
4.172 kB
react-text
Text - Wrappers
13.899 kB
4.513 kB
react-theme
Teams: all themes
25.334 kB
6.012 kB
react-theme
Teams: Light theme
16.937 kB
4.948 kB
react-tooltip
Tooltip
43.871 kB
15.165 kB
react-utilities
SSRProvider
189 B
161 B
🤖 This report was generated against ed9dfd8e9ba2b0920f6c4bc396204b4ced4cacb2

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 901 951 5000
BaseButton mount 924 912 5000
Breadcrumb mount 2644 2623 1000
ButtonNext mount 520 500 5000
Checkbox mount 1540 1553 5000
CheckboxBase mount 1282 1269 5000
ChoiceGroup mount 4679 4690 5000
ComboBox mount 984 976 1000
CommandBar mount 10174 10209 1000
ContextualMenu mount 6471 6385 1000
DefaultButton mount 1134 1148 5000
DetailsRow mount 3832 3744 5000
DetailsRowFast mount 3813 3803 5000
DetailsRowNoStyles mount 3591 3622 5000
Dialog mount 2592 2599 1000
DocumentCardTitle mount 169 160 1000
Dropdown mount 3183 3219 5000
FluentProviderNext mount 3862 3910 5000
FluentProviderWithTheme mount 225 217 10
FluentProviderWithTheme virtual-rerender 98 112 10
FluentProviderWithTheme virtual-rerender-with-unmount 251 259 10
FocusTrapZone mount 1775 1769 5000
FocusZone mount 1784 1839 5000
IconButton mount 1803 1787 5000
Label mount 363 353 5000
Layer mount 2906 2960 5000
Link mount 489 472 5000
MakeStyles mount 1834 1839 50000
MenuButton mount 1506 1461 5000
MessageBar mount 2011 2019 5000
Nav mount 3338 3280 1000
OverflowSet mount 1133 1117 5000
Panel mount 2481 2483 1000
Persona mount 849 850 1000
Pivot mount 1439 1486 1000
PrimaryButton mount 1339 1296 5000
Rating mount 7704 7649 5000
SearchBox mount 1352 1321 5000
Shimmer mount 2507 2547 5000
Slider mount 1997 1966 5000
SpinButton mount 4939 4972 5000
Spinner mount 410 433 5000
SplitButton mount 3208 3201 5000
Stack mount 512 517 5000
StackWithIntrinsicChildren mount 1713 1686 5000
StackWithTextChildren mount 4623 4583 5000
SwatchColorPicker mount 10483 10514 5000
TagPicker mount 2598 2653 5000
TeachingBubble mount 12724 12928 5000
Text mount 425 438 5000
TextField mount 1397 1381 5000
ThemeProvider mount 1202 1230 5000
ThemeProvider virtual-rerender 615 617 5000
ThemeProvider virtual-rerender-with-unmount 1917 1912 5000
Toggle mount 818 821 5000
buttonNative mount 135 138 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
CarouselMinimalPerf.default 478 443 1.08:1
LayoutMinimalPerf.default 394 368 1.07:1
SkeletonMinimalPerf.default 370 352 1.05:1
AvatarMinimalPerf.default 199 192 1.04:1
RadioGroupMinimalPerf.default 460 444 1.04:1
TreeMinimalPerf.default 812 781 1.04:1
ButtonSlotsPerf.default 551 533 1.03:1
CheckboxMinimalPerf.default 2785 2707 1.03:1
DialogMinimalPerf.default 772 748 1.03:1
ListWith60ListItems.default 660 640 1.03:1
PortalMinimalPerf.default 181 176 1.03:1
StatusMinimalPerf.default 690 673 1.03:1
TreeWith60ListItems.default 180 174 1.03:1
AttachmentSlotsPerf.default 1079 1058 1.02:1
ChatMinimalPerf.default 653 643 1.02:1
FlexMinimalPerf.default 297 290 1.02:1
FormMinimalPerf.default 409 401 1.02:1
MenuMinimalPerf.default 838 820 1.02:1
ProviderMinimalPerf.default 1130 1109 1.02:1
ReactionMinimalPerf.default 384 376 1.02:1
SplitButtonMinimalPerf.default 4278 4204 1.02:1
TableManyItemsPerf.default 1903 1871 1.02:1
BoxMinimalPerf.default 350 346 1.01:1
ButtonOverridesMissPerf.default 1781 1755 1.01:1
CardMinimalPerf.default 547 540 1.01:1
DropdownMinimalPerf.default 3213 3182 1.01:1
SegmentMinimalPerf.default 356 351 1.01:1
DropdownManyItemsPerf.default 692 689 1:1
GridMinimalPerf.default 344 345 1:1
HeaderMinimalPerf.default 358 357 1:1
HeaderSlotsPerf.default 758 758 1:1
InputMinimalPerf.default 1317 1319 1:1
ItemLayoutMinimalPerf.default 1207 1205 1:1
ListCommonPerf.default 637 634 1:1
ListMinimalPerf.default 497 499 1:1
LoaderMinimalPerf.default 709 706 1:1
MenuButtonMinimalPerf.default 1647 1642 1:1
SliderMinimalPerf.default 1706 1711 1:1
IconMinimalPerf.default 615 615 1:1
TableMinimalPerf.default 403 403 1:1
CustomToolbarPrototype.default 4090 4093 1:1
ToolbarMinimalPerf.default 930 929 1:1
AccordionMinimalPerf.default 153 154 0.99:1
AnimationMinimalPerf.default 413 417 0.99:1
ImageMinimalPerf.default 374 376 0.99:1
LabelMinimalPerf.default 388 391 0.99:1
ProviderMergeThemesPerf.default 1717 1734 0.99:1
TextMinimalPerf.default 346 348 0.99:1
AttachmentMinimalPerf.default 158 161 0.98:1
ChatWithPopoverPerf.default 385 393 0.98:1
DividerMinimalPerf.default 353 360 0.98:1
EmbedMinimalPerf.default 4251 4318 0.98:1
PopupMinimalPerf.default 588 597 0.98:1
RefMinimalPerf.default 231 236 0.98:1
TextAreaMinimalPerf.default 489 497 0.98:1
TooltipMinimalPerf.default 1023 1041 0.98:1
DatepickerMinimalPerf.default 5405 5559 0.97:1
ListNestedPerf.default 543 557 0.97:1
VideoMinimalPerf.default 610 631 0.97:1
ButtonMinimalPerf.default 178 185 0.96:1
RosterPerf.default 1172 1218 0.96:1
AlertMinimalPerf.default 269 283 0.95:1
ChatDuplicateMessagesPerf.default 282 311 0.91:1

@ling1726 ling1726 merged commit a118c7f into microsoft:master Nov 5, 2021
mlp73 pushed a commit to mlp73/fluentui that referenced this pull request Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants