Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove test-bundles which doesnt exist anymore - leftover of bad rebase #28374

Merged

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Jun 29, 2023

New Behavior

see PR description

Related Issue(s)

@github-actions github-actions bot added this to the June Project Cycle Q2 2023 milestone Jun 29, 2023
@Hotell Hotell marked this pull request as ready for review June 29, 2023 11:33
@Hotell Hotell requested a review from a team as a code owner June 29, 2023 11:33
@Hotell Hotell enabled auto-merge (squash) June 29, 2023 11:33
@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
FluentProviderWithTheme virtual-rerender-with-unmount 76 68 10 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 608 605 5000
Button mount 297 281 5000
Field mount 1021 1054 5000
FluentProvider mount 634 632 5000
FluentProviderWithTheme mount 77 78 10
FluentProviderWithTheme virtual-rerender 71 71 10
FluentProviderWithTheme virtual-rerender-with-unmount 76 68 10 Possible regression
InfoButton mount 15 15 5000
MakeStyles mount 850 832 50000
Persona mount 1606 1626 5000
SpinButton mount 1266 1317 5000

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 15ac59c:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-northstar)

⚠️ 1 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
AccordionMinimalPerf.default 76 87 0.87:1 analysis
Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ButtonMinimalPerf.default 95 84 1.13:1
CardMinimalPerf.default 317 294 1.08:1
AlertMinimalPerf.default 158 147 1.07:1
AttachmentSlotsPerf.default 654 611 1.07:1
LayoutMinimalPerf.default 208 196 1.06:1
RefMinimalPerf.default 110 105 1.05:1
SkeletonMinimalPerf.default 203 193 1.05:1
IconMinimalPerf.default 399 380 1.05:1
TextAreaMinimalPerf.default 301 288 1.05:1
RadioGroupMinimalPerf.default 265 254 1.04:1
VideoMinimalPerf.default 438 420 1.04:1
BoxMinimalPerf.default 192 187 1.03:1
DropdownMinimalPerf.default 1450 1403 1.03:1
RosterPerf.default 1540 1491 1.03:1
DialogMinimalPerf.default 454 444 1.02:1
ImageMinimalPerf.default 222 218 1.02:1
MenuButtonMinimalPerf.default 960 941 1.02:1
ProviderMinimalPerf.default 201 198 1.02:1
SplitButtonMinimalPerf.default 2313 2270 1.02:1
CustomToolbarPrototype.default 1469 1447 1.02:1
ToolbarMinimalPerf.default 551 538 1.02:1
ButtonOverridesMissPerf.default 646 640 1.01:1
CarouselMinimalPerf.default 257 255 1.01:1
ChatWithPopoverPerf.default 188 186 1.01:1
DatepickerMinimalPerf.default 3525 3484 1.01:1
EmbedMinimalPerf.default 1838 1819 1.01:1
GridMinimalPerf.default 190 188 1.01:1
HeaderSlotsPerf.default 458 455 1.01:1
LabelMinimalPerf.default 220 218 1.01:1
ListCommonPerf.default 394 390 1.01:1
ListNestedPerf.default 326 322 1.01:1
PopupMinimalPerf.default 347 342 1.01:1
TreeMinimalPerf.default 468 465 1.01:1
AttachmentMinimalPerf.default 81 81 1:1
AvatarMinimalPerf.default 113 113 1:1
ItemLayoutMinimalPerf.default 719 722 1:1
MenuMinimalPerf.default 487 485 1:1
PortalMinimalPerf.default 83 83 1:1
ProviderMergeThemesPerf.default 649 652 1:1
TableManyItemsPerf.default 1117 1115 1:1
TooltipMinimalPerf.default 1261 1257 1:1
AnimationMinimalPerf.default 298 302 0.99:1
ChatDuplicateMessagesPerf.default 149 150 0.99:1
ChatMinimalPerf.default 435 439 0.99:1
CheckboxMinimalPerf.default 1120 1135 0.99:1
DropdownManyItemsPerf.default 386 391 0.99:1
HeaderMinimalPerf.default 205 208 0.99:1
LoaderMinimalPerf.default 181 183 0.99:1
TextMinimalPerf.default 193 195 0.99:1
DividerMinimalPerf.default 194 197 0.98:1
InputMinimalPerf.default 531 541 0.98:1
ListMinimalPerf.default 301 308 0.98:1
FlexMinimalPerf.default 154 158 0.97:1
ListWith60ListItems.default 368 378 0.97:1
SliderMinimalPerf.default 732 752 0.97:1
TableMinimalPerf.default 228 234 0.97:1
TreeWith60ListItems.default 88 91 0.97:1
FormMinimalPerf.default 213 222 0.96:1
ReactionMinimalPerf.default 215 224 0.96:1
SegmentMinimalPerf.default 197 209 0.94:1
StatusMinimalPerf.default 382 405 0.94:1
ButtonSlotsPerf.default 312 345 0.9:1

@fabricteam
Copy link
Collaborator

🕵 fluentuiv8 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext
510 B
330 B
global-context
createContextSelector
537 B
342 B
priority-overflow
createOverflowManager
4.248 kB
1.671 kB
react-accordion
Accordion (including children components)
88.246 kB
26.712 kB
react-alert
Alert
82.552 kB
21.771 kB
react-avatar
Avatar
47.7 kB
14.504 kB
react-avatar
AvatarGroup
15.682 kB
6.306 kB
react-avatar
AvatarGroupItem
63.876 kB
18.984 kB
react-badge
Badge
23.591 kB
7.264 kB
react-badge
CounterBadge
24.493 kB
7.565 kB
react-badge
PresenceBadge
22.213 kB
7.872 kB
react-button
Button
36.778 kB
9.51 kB
react-button
CompoundButton
43.932 kB
10.99 kB
react-button
MenuButton
40.965 kB
10.705 kB
react-button
SplitButton
49.197 kB
12.27 kB
react-button
ToggleButton
55.06 kB
11.446 kB
react-card
Card - All
89.11 kB
25.236 kB
react-card
Card
83.764 kB
23.685 kB
react-card
CardFooter
9.229 kB
3.9 kB
react-card
CardHeader
11.402 kB
4.683 kB
react-card
CardPreview
10.034 kB
4.248 kB
react-checkbox
Checkbox
33.164 kB
10.699 kB
react-combobox
Combobox (including child components)
86.98 kB
28.084 kB
react-combobox
Dropdown (including child components)
85.321 kB
27.675 kB
react-components
react-components: Button, FluentProvider & webLightTheme
65.162 kB
17.952 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
210.395 kB
58.717 kB
react-components
react-components: FluentProvider & webLightTheme
36.395 kB
11.996 kB
react-datepicker-compat
DatePicker Compat
221.924 kB
59.118 kB
react-dialog
Dialog (including children components)
92.138 kB
27.487 kB
react-divider
Divider
17.477 kB
6.357 kB
react-field
Field
18.003 kB
6.931 kB
react-image
Image
11.55 kB
4.627 kB
react-infobutton
InfoButton
131.191 kB
40.269 kB
react-infobutton
InfoLabel
134.656 kB
41.338 kB
react-input
Input
24.219 kB
7.781 kB
react-label
Label
10.175 kB
4.243 kB
react-link
Link
12.375 kB
5.113 kB
react-menu
Menu (including children components)
132.388 kB
40.52 kB
react-menu
Menu (including selectable components)
135.152 kB
41.012 kB
react-overflow
hooks only
12.505 kB
4.626 kB
react-persona
Persona
54.621 kB
16.435 kB
react-popover
Popover
119.781 kB
36.844 kB
react-portal
Portal
11.82 kB
4.391 kB
react-portal-compat
PortalCompatProvider
6.473 kB
2.196 kB
react-positioning
usePositioning
24.249 kB
8.856 kB
react-progress
ProgressBar
13.927 kB
5.488 kB
react-provider
FluentProvider
18.115 kB
6.719 kB
react-radio
Radio
26.952 kB
8.608 kB
react-radio
RadioGroup
11.362 kB
4.753 kB
react-select
Select
24.915 kB
8.708 kB
react-slider
Slider
34.358 kB
11.107 kB
react-spinbutton
SpinButton
33.452 kB
10.296 kB
react-spinner
Spinner
21.363 kB
7.021 kB
react-switch
Switch
29.472 kB
9.226 kB
react-table
DataGrid
156.649 kB
42.835 kB
react-table
Table (Primitives only)
44.652 kB
12.468 kB
react-table
Table as DataGrid
132.304 kB
33.864 kB
react-table
Table (Selection only)
77.906 kB
19.26 kB
react-table
Table (Sort only)
76.891 kB
18.989 kB
react-tags
Tag
23.162 kB
7.925 kB
react-text
Text - Default
12.563 kB
4.972 kB
react-text
Text - Wrappers
15.713 kB
5.293 kB
react-textarea
Textarea
27.69 kB
9.125 kB
react-theme
Single theme token import
69 B
89 B
react-theme
Teams: all themes
31.987 kB
6.85 kB
react-theme
Teams: Light theme
18.121 kB
5.194 kB
react-tooltip
Tooltip
47.319 kB
16.618 kB
react-utilities
SSRProvider
180 B
159 B
🤖 This report was generated against 7d519bdcaef0a3249b6eae721fea0e5f096f6d35

@fabricteam
Copy link
Collaborator

🕵 FluentUI-v0 No visual regressions between this PR and main

@size-auditor
Copy link

size-auditor bot commented Jun 29, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 7d519bdcaef0a3249b6eae721fea0e5f096f6d35 (build)

@fabricteam
Copy link
Collaborator

🕵 fluentuiv9 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 605 613 5000
Breadcrumb mount 1642 1678 1000
Checkbox mount 1681 1707 5000
CheckboxBase mount 1463 1467 5000
ChoiceGroup mount 2950 2940 5000
ComboBox mount 643 656 1000
CommandBar mount 6282 6159 1000
ContextualMenu mount 11969 12056 1000
DefaultButton mount 743 761 5000
DetailsRow mount 2134 2158 5000
DetailsRowFast mount 2171 2155 5000
DetailsRowNoStyles mount 2030 2041 5000
Dialog mount 2643 2597 1000
DocumentCardTitle mount 231 226 1000
Dropdown mount 2013 1924 5000
FocusTrapZone mount 1126 1136 5000
FocusZone mount 1055 1035 5000
GroupedList mount 40805 41158 2
GroupedList virtual-rerender 19641 19759 2
GroupedList virtual-rerender-with-unmount 50714 50096 2
GroupedListV2 mount 214 211 2
GroupedListV2 virtual-rerender 203 212 2
GroupedListV2 virtual-rerender-with-unmount 225 237 2
IconButton mount 1101 1057 5000
Label mount 331 338 5000
Layer mount 2683 2764 5000
Link mount 377 392 5000
MenuButton mount 921 916 5000
MessageBar mount 21031 21196 5000
Nav mount 1928 1904 1000
OverflowSet mount 790 766 5000
Panel mount 1753 1806 1000
Persona mount 742 733 1000
Pivot mount 853 866 1000
PrimaryButton mount 832 841 5000
Rating mount 4567 4605 5000
SearchBox mount 912 922 5000
Shimmer mount 1865 1876 5000
Slider mount 1324 1335 5000
SpinButton mount 2818 2860 5000
Spinner mount 396 377 5000
SplitButton mount 1803 1819 5000
Stack mount 420 402 5000
StackWithIntrinsicChildren mount 868 827 5000
StackWithTextChildren mount 2625 2655 5000
SwatchColorPicker mount 6047 6075 5000
TagPicker mount 1450 1451 5000
Text mount 372 365 5000
TextField mount 942 927 5000
ThemeProvider mount 829 840 5000
ThemeProvider virtual-rerender 588 580 5000
ThemeProvider virtual-rerender-with-unmount 1299 1274 5000
Toggle mount 613 606 5000
buttonNative mount 189 186 5000

@Hotell Hotell merged commit 09765ca into microsoft:master Jun 29, 2023
@Hotell Hotell deleted the hotell/build/nx/migrate-to-15-x-leftover branch June 29, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants