fix(scripts/generators): make sure to flush nx Tree outside nx context in order to write changes on physical file system #28396

Hotell · 2023-06-30T10:06:00Z

Previous Behavior

yarn create-component doesn't work after migration to nx 15.9 which introduced project.json per package instead global workspace.json. This change needed us to monkey patch how nx devkit is used outside nx environment, but we forgot to flush the virtual FS tree to real FS.

New Behavior

yarn create-component does work

Related Issue(s)

Follows chore: migrate from nx 15.6.3 to 15.9.5 #28032

…t in order to write changes on physical file system

fabricteam · 2023-06-30T10:14:57Z

Perf Analysis (`@fluentui/react-components`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
Avatar	mount	601	598	5000
Button	mount	295	298	5000
Field	mount	1067	1065	5000
FluentProvider	mount	643	667	5000
FluentProviderWithTheme	mount	76	82	10
FluentProviderWithTheme	virtual-rerender	66	61	10
FluentProviderWithTheme	virtual-rerender-with-unmount	62	75	10
InfoButton	mount	13	11	5000
MakeStyles	mount	866	865	50000
Persona	mount	1638	1579	5000
SpinButton	mount	1321	1307	5000

fabricteam · 2023-06-30T10:17:46Z

Perf Analysis (`@fluentui/react-northstar`)

⚠️ 1 potential perf regressions detected

Potential regressions comparing to master

Scenario	Current PR Ticks	Baseline Ticks	Ratio	Regression Analysis
AccordionMinimalPerf.default	80	86	0.93:1	analysis

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
AttachmentMinimalPerf.default	84	75	1.12:1
ReactionMinimalPerf.default	223	202	1.1:1
ListWith60ListItems.default	383	353	1.08:1
PortalMinimalPerf.default	82	76	1.08:1
ButtonMinimalPerf.default	93	87	1.07:1
ChatWithPopoverPerf.default	194	182	1.07:1
CardMinimalPerf.default	332	312	1.06:1
HeaderMinimalPerf.default	213	203	1.05:1
StatusMinimalPerf.default	412	394	1.05:1
TreeMinimalPerf.default	487	466	1.05:1
ImageMinimalPerf.default	223	215	1.04:1
LabelMinimalPerf.default	224	216	1.04:1
IconMinimalPerf.default	396	382	1.04:1
TableMinimalPerf.default	241	232	1.04:1
ToolbarMinimalPerf.default	539	520	1.04:1
BoxMinimalPerf.default	198	192	1.03:1
ButtonOverridesMissPerf.default	652	631	1.03:1
FormMinimalPerf.default	227	220	1.03:1
TextMinimalPerf.default	191	186	1.03:1
AnimationMinimalPerf.default	305	298	1.02:1
AvatarMinimalPerf.default	108	106	1.02:1
ChatMinimalPerf.default	440	431	1.02:1
DropdownMinimalPerf.default	1424	1398	1.02:1
ListMinimalPerf.default	304	299	1.02:1
MenuButtonMinimalPerf.default	970	950	1.02:1
RosterPerf.default	1519	1489	1.02:1
TableManyItemsPerf.default	1134	1115	1.02:1
TooltipMinimalPerf.default	1277	1253	1.02:1
CheckboxMinimalPerf.default	1134	1120	1.01:1
DropdownManyItemsPerf.default	389	386	1.01:1
PopupMinimalPerf.default	350	347	1.01:1
ProviderMinimalPerf.default	204	201	1.01:1
SegmentMinimalPerf.default	203	201	1.01:1
TreeWith60ListItems.default	88	87	1.01:1
AttachmentSlotsPerf.default	645	644	1:1
TextAreaMinimalPerf.default	290	291	1:1
VideoMinimalPerf.default	445	445	1:1
DatepickerMinimalPerf.default	3553	3607	0.99:1
InputMinimalPerf.default	530	534	0.99:1
ListNestedPerf.default	311	313	0.99:1
ProviderMergeThemesPerf.default	667	671	0.99:1
RadioGroupMinimalPerf.default	259	262	0.99:1
SplitButtonMinimalPerf.default	2263	2294	0.99:1
CustomToolbarPrototype.default	1476	1491	0.99:1
DialogMinimalPerf.default	444	455	0.98:1
EmbedMinimalPerf.default	1824	1869	0.98:1
ItemLayoutMinimalPerf.default	714	727	0.98:1
SkeletonMinimalPerf.default	195	200	0.98:1
SliderMinimalPerf.default	744	761	0.98:1
LayoutMinimalPerf.default	197	204	0.97:1
RefMinimalPerf.default	107	110	0.97:1
ChatDuplicateMessagesPerf.default	152	158	0.96:1
FlexMinimalPerf.default	154	160	0.96:1
GridMinimalPerf.default	186	193	0.96:1
HeaderSlotsPerf.default	459	476	0.96:1
ListCommonPerf.default	383	399	0.96:1
AlertMinimalPerf.default	149	157	0.95:1
LoaderMinimalPerf.default	184	193	0.95:1
CarouselMinimalPerf.default	252	269	0.94:1
DividerMinimalPerf.default	198	211	0.94:1
MenuMinimalPerf.default	484	514	0.94:1
ButtonSlotsPerf.default	317	345	0.92:1

codesandbox-ci · 2023-06-30T10:18:58Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 07eae4a:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

fabricteam · 2023-06-30T10:19:05Z

🕵 fluentuiv8 No visual regressions between this PR and main

fabricteam · 2023-06-30T10:24:22Z

📊 Bundle size report

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`global-context` createContext	`510 B` `330 B`
`global-context` createContextSelector	`537 B` `342 B`
`priority-overflow` createOverflowManager	`4.248 kB` `1.671 kB`
`react-accordion` Accordion (including children components)	`88.246 kB` `26.712 kB`
`react-alert` Alert	`82.552 kB` `21.771 kB`
`react-avatar` Avatar	`47.7 kB` `14.504 kB`
`react-avatar` AvatarGroup	`15.682 kB` `6.306 kB`
`react-avatar` AvatarGroupItem	`63.876 kB` `18.984 kB`
`react-badge` Badge	`23.591 kB` `7.264 kB`
`react-badge` CounterBadge	`24.493 kB` `7.565 kB`
`react-badge` PresenceBadge	`22.213 kB` `7.872 kB`
`react-button` Button	`36.778 kB` `9.51 kB`
`react-button` CompoundButton	`43.932 kB` `10.99 kB`
`react-button` MenuButton	`40.965 kB` `10.705 kB`
`react-button` SplitButton	`49.197 kB` `12.27 kB`
`react-button` ToggleButton	`55.06 kB` `11.446 kB`
`react-card` Card - All	`89.11 kB` `25.236 kB`
`react-card` Card	`83.764 kB` `23.685 kB`
`react-card` CardFooter	`9.229 kB` `3.9 kB`
`react-card` CardHeader	`11.402 kB` `4.683 kB`
`react-card` CardPreview	`10.034 kB` `4.248 kB`
`react-checkbox` Checkbox	`33.164 kB` `10.699 kB`
`react-combobox` Combobox (including child components)	`86.98 kB` `28.084 kB`
`react-combobox` Dropdown (including child components)	`85.321 kB` `27.675 kB`
`react-components` react-components: Button, FluentProvider & webLightTheme	`65.162 kB` `17.952 kB`
`react-components` react-components: Accordion, Button, FluentProvider, Image, Menu, Popover	`210.395 kB` `58.717 kB`
`react-components` react-components: FluentProvider & webLightTheme	`36.395 kB` `11.996 kB`
`react-datepicker-compat` DatePicker Compat	`221.924 kB` `59.118 kB`
`react-dialog` Dialog (including children components)	`92.138 kB` `27.487 kB`
`react-divider` Divider	`17.477 kB` `6.357 kB`
`react-field` Field	`18.003 kB` `6.931 kB`
`react-image` Image	`11.55 kB` `4.627 kB`
`react-infobutton` InfoButton	`131.191 kB` `40.269 kB`
`react-infobutton` InfoLabel	`134.656 kB` `41.338 kB`
`react-input` Input	`24.219 kB` `7.781 kB`
`react-label` Label	`10.175 kB` `4.243 kB`
`react-link` Link	`12.771 kB` `5.237 kB`
`react-menu` Menu (including children components)	`132.388 kB` `40.52 kB`
`react-menu` Menu (including selectable components)	`135.152 kB` `41.012 kB`
`react-overflow` hooks only	`12.505 kB` `4.626 kB`
`react-persona` Persona	`54.621 kB` `16.435 kB`
`react-popover` Popover	`119.781 kB` `36.844 kB`
`react-portal` Portal	`11.82 kB` `4.391 kB`
`react-portal-compat` PortalCompatProvider	`6.473 kB` `2.196 kB`
`react-positioning` usePositioning	`24.249 kB` `8.856 kB`
`react-progress` ProgressBar	`13.927 kB` `5.488 kB`
`react-provider` FluentProvider	`18.115 kB` `6.719 kB`
`react-radio` Radio	`26.952 kB` `8.608 kB`
`react-radio` RadioGroup	`11.362 kB` `4.753 kB`
`react-select` Select	`24.915 kB` `8.708 kB`
`react-slider` Slider	`34.358 kB` `11.107 kB`
`react-spinbutton` SpinButton	`33.452 kB` `10.296 kB`
`react-spinner` Spinner	`21.363 kB` `7.021 kB`
`react-switch` Switch	`29.472 kB` `9.226 kB`
`react-table` DataGrid	`156.649 kB` `42.835 kB`
`react-table` Table (Primitives only)	`44.652 kB` `12.468 kB`
`react-table` Table as DataGrid	`132.304 kB` `33.864 kB`
`react-table` Table (Selection only)	`77.906 kB` `19.26 kB`
`react-table` Table (Sort only)	`76.891 kB` `18.989 kB`
`react-tags` Tag	`23.162 kB` `7.925 kB`
`react-text` Text - Default	`12.563 kB` `4.972 kB`
`react-text` Text - Wrappers	`15.713 kB` `5.293 kB`
`react-textarea` Textarea	`27.69 kB` `9.125 kB`
`react-theme` Single theme token import	`69 B` `89 B`
`react-theme` Teams: all themes	`31.987 kB` `6.85 kB`
`react-theme` Teams: Light theme	`18.121 kB` `5.194 kB`
`react-tooltip` Tooltip	`47.319 kB` `16.618 kB`
`react-utilities` SSRProvider	`180 B` `159 B`

_{🤖 This report was generated against 1745a0bfdb5ad5a0757fe57e2c698bc170a34cfe}

fabricteam · 2023-06-30T10:25:45Z

🕵 FluentUI-v0 No visual regressions between this PR and main

size-auditor · 2023-06-30T10:25:53Z

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 1745a0bfdb5ad5a0757fe57e2c698bc170a34cfe (build)

fabricteam · 2023-06-30T10:27:14Z

🕵 fluentuiv9 No visual regressions between this PR and main

fabricteam · 2023-06-30T10:29:56Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
BaseButton	mount	621	652	5000
Breadcrumb	mount	1646	1672	1000
Checkbox	mount	1671	1687	5000
CheckboxBase	mount	1467	1478	5000
ChoiceGroup	mount	2917	2916	5000
ComboBox	mount	665	656	1000
CommandBar	mount	6180	6238	1000
ContextualMenu	mount	11884	11721	1000
DefaultButton	mount	745	740	5000
DetailsRow	mount	2164	2148	5000
DetailsRowFast	mount	2163	2211	5000
DetailsRowNoStyles	mount	2001	2016	5000
Dialog	mount	2620	2755	1000
DocumentCardTitle	mount	213	213	1000
Dropdown	mount	1965	1945	5000
FocusTrapZone	mount	1145	1136	5000
FocusZone	mount	1079	1070	5000
GroupedList	mount	40959	41233	2
GroupedList	virtual-rerender	19622	19665	2
GroupedList	virtual-rerender-with-unmount	49863	50269	2
GroupedListV2	mount	220	221	2
GroupedListV2	virtual-rerender	213	208	2
GroupedListV2	virtual-rerender-with-unmount	221	221	2
IconButton	mount	1065	1078	5000
Label	mount	332	327	5000
Layer	mount	2759	2735	5000
Link	mount	389	389	5000
MenuButton	mount	924	922	5000
MessageBar	mount	21334	21419	5000
Nav	mount	1945	1924	1000
OverflowSet	mount	780	777	5000
Panel	mount	1804	1781	1000
Persona	mount	744	763	1000
Pivot	mount	863	888	1000
PrimaryButton	mount	852	841	5000
Rating	mount	4621	4641	5000
SearchBox	mount	910	906	5000
Shimmer	mount	1856	1846	5000
Slider	mount	1300	1344	5000
SpinButton	mount	2947	2844	5000
Spinner	mount	388	385	5000
SplitButton	mount	1773	1782	5000
Stack	mount	398	398	5000
StackWithIntrinsicChildren	mount	865	865	5000
StackWithTextChildren	mount	2613	2673	5000
SwatchColorPicker	mount	6062	6018	5000
TagPicker	mount	1438	1442	5000
Text	mount	377	376	5000
TextField	mount	944	936	5000
ThemeProvider	mount	849	835	5000
ThemeProvider	virtual-rerender	596	588	5000
ThemeProvider	virtual-rerender-with-unmount	1276	1294	5000
Toggle	mount	601	614	5000
buttonNative	mount	189	187	5000

fix(scripts/generators): make sure to flush nx Tree outside nx contex…

07eae4a

…t in order to write changes on physical file system

msft-fluent-ui-bot added the Area: Build System label Jun 30, 2023

msft-fluent-ui-bot assigned tomi-msft Jun 30, 2023

Hotell changed the title ~~fix(scripts/generators): make sure to flush nx Tree outside nx contex…~~ fix(scripts/generators): make sure to flush nx Tree outside nx context in order to write changes on physical file system Jun 30, 2023

github-actions bot added this to the June Project Cycle Q2 2023 milestone Jun 30, 2023

Hotell unassigned tomi-msft Jun 30, 2023

Hotell added the Fluent UI react-components (v9) label Jun 30, 2023

Hotell marked this pull request as ready for review June 30, 2023 10:14

Hotell requested a review from a team as a code owner June 30, 2023 10:14

Hotell enabled auto-merge (squash) June 30, 2023 10:19

ling1726 approved these changes Jun 30, 2023

View reviewed changes

Hotell merged commit 2d874b5 into microsoft:master Jun 30, 2023

Hotell deleted the hotell/build/fix-broken-create-component-after-nx15dot9 branch June 30, 2023 11:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(scripts/generators): make sure to flush nx Tree outside nx context in order to write changes on physical file system #28396

fix(scripts/generators): make sure to flush nx Tree outside nx context in order to write changes on physical file system #28396

Hotell commented Jun 30, 2023 •

edited

Loading

fabricteam commented Jun 30, 2023

fabricteam commented Jun 30, 2023

codesandbox-ci bot commented Jun 30, 2023

fabricteam commented Jun 30, 2023

fabricteam commented Jun 30, 2023

fabricteam commented Jun 30, 2023

size-auditor bot commented Jun 30, 2023

fabricteam commented Jun 30, 2023

fabricteam commented Jun 30, 2023

fix(scripts/generators): make sure to flush nx Tree outside nx context in order to write changes on physical file system #28396

fix(scripts/generators): make sure to flush nx Tree outside nx context in order to write changes on physical file system #28396

Conversation

Hotell commented Jun 30, 2023 • edited Loading

Previous Behavior

New Behavior

Related Issue(s)

fabricteam commented Jun 30, 2023

Perf Analysis (@fluentui/react-components)

fabricteam commented Jun 30, 2023

Perf Analysis (@fluentui/react-northstar)

Potential regressions comparing to master

codesandbox-ci bot commented Jun 30, 2023

fabricteam commented Jun 30, 2023

🕵 fluentuiv8 No visual regressions between this PR and main

fabricteam commented Jun 30, 2023

📊 Bundle size report

fabricteam commented Jun 30, 2023

🕵 FluentUI-v0 No visual regressions between this PR and main

size-auditor bot commented Jun 30, 2023

Asset size changes

fabricteam commented Jun 30, 2023

🕵 fluentuiv9 No visual regressions between this PR and main

fabricteam commented Jun 30, 2023

Perf Analysis (@fluentui/react)

Hotell commented Jun 30, 2023 •

edited

Loading

Perf Analysis (`@fluentui/react-components`)

Perf Analysis (`@fluentui/react-northstar`)

Perf Analysis (`@fluentui/react`)