-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Test change] [Not to merge] Change to enable charts on docsite as PR demosite is not working #33407
Draft
AtishayMsft
wants to merge
5
commits into
master
Choose a base branch
from
charting/declarativeChartDocsite
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabricteam
reviewed
Dec 4, 2024
@@ -108,6 +108,7 @@ module.exports = { | |||
'MultiStackedBarChart', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕵🏾♀️ visual regressions to review in the fluentuiv8 Visual Regression Report
Callout 2 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
Callout.Bottom right edge.chromium.png | 1596 | Changed |
Callout.Left top edge.chromium.png | 1949 | Changed |
react-charting-AreaChart 1 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
react-charting-AreaChart.Custom Accessibility.chromium.png | 11 | Changed |
react-charting-LineChart 1 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
react-charting-LineChart.Gaps.chromium.png | 1 | Changed |
📊 Bundle size reportUnchanged fixtures
|
🕵 FluentUIV0 No visual regressions between this PR and main |
Pull request demo site: URL |
fabricteam
reviewed
Dec 4, 2024
@@ -108,6 +108,7 @@ module.exports = { | |||
'MultiStackedBarChart', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕵🏾♀️ visual regressions to review in the fluentuiv9 Visual Regression Report
Avatar Converged 2 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
Avatar Converged.Badge Mask RTL.chromium.png | 31 | Changed |
Avatar Converged.badgeMask.chromium.png | 2 | Changed |
Drawer 1 screenshots
Image Name | Diff(in Pixels) | Image Type |
---|---|---|
Drawer.overlay drawer full.chromium.png | 1139 | Changed |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
New Behavior
Related Issue(s)