Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eslint-plugin-react-components): add prefer-fluentui-v9 rule #33449

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

feat(eslint-plugin-react-components): add prefer-fluentui-v9 rule #33449

wants to merge 12 commits into from

Conversation

dmytrokirpa
Copy link
Contributor

Previous Behavior

--

New Behavior

  • Added new rule prefer-fluentui-v9 to eslint-plugin-react-components to enforce the use of Fluent UI v9 equivalent for Fluent UI v8 components.
  • Added it to the recommended config.
  • Updated docs

Example of output:

fluentui/apps/vr-tests/src/stories/Toggle.stories.tsx
  4:1  warning  Avoid importing Toggle from '@fluentui/react', as this package has already migrated to Fluent UI 9. Import Switch from '@fluentui/react-components' instead  @fluentui/react-components/prefer-fluentui-v9

fluentui/apps/vr-tests/src/stories/Tooltip/Tooltip.stories.tsx
  4:1  warning  Avoid importing TooltipHost from '@fluentui/react', as this package has already migrated to Fluent UI 9. Import Tooltip from '@fluentui/react-components' instead  @fluentui/react-components/prefer-fluentui-v9

Related Issue(s)

@dmytrokirpa dmytrokirpa requested review from a team December 11, 2024 14:45
@dmytrokirpa dmytrokirpa self-assigned this Dec 11, 2024
@dmytrokirpa dmytrokirpa requested a review from a team as a code owner December 11, 2024 14:45
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 11, 2024 •
edited
Loading

📊 Bundle size report

✅ No changes found

@dmytrokirpa
Copy link
Contributor Author

cc @NotWoods

@github-actions GitHub Actions
Copy link

Pull request demo site: URL

@dmytrokirpa dmytrokirpa requested review from NotWoods and mainframev and removed request for NotWoods December 12, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NotWoods NotWoods NotWoods approved these changes

@mainframev mainframev Awaiting requested review from mainframev

At least 1 approving review is required to merge this pull request.

Assignees

@dmytrokirpa dmytrokirpa

Labels
Fluent UI react-components (v9) Package: eslint-plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmytrokirpa @NotWoods