Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Collapse): streamline atom functions #33463

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

robertpenner
Copy link
Collaborator

@robertpenner robertpenner commented Dec 12, 2024

Previous Behavior

  • Duplication in enter/exit implementations in atom functions:
    • opacity
    • whitespace
  • No fade atom function in common location

New Behavior

  • Duplication factored out
  • fadeAtom is in a common location and Collapse imports it for reuse
  • Added comments and explanatory types as needed

Future Work

  • Use fadeAtom in other motion components wherever possible

Related Issue(s)

@robertpenner robertpenner self-assigned this Dec 12, 2024
Copy link

github-actions bot commented Dec 12, 2024

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-accordion
Accordion (including children components)
107.08 kB
32.786 kB
106.922 kB
32.796 kB
-158 B
10 B
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
222.703 kB
64.42 kB
222.545 kB
64.43 kB
-158 B
10 B
react-components
react-components: entire library
1.164 MB
291.232 kB
1.164 MB
291.242 kB
-158 B
10 B
react-toast
Toast (including Toaster)
101.371 kB
30.477 kB
101.213 kB
30.472 kB
-158 B
-5 B
react-tree
FlatTree
145.462 kB
41.771 kB
145.302 kB
41.779 kB
-160 B
8 B
react-tree
PersonaFlatTree
146.15 kB
41.881 kB
145.99 kB
41.89 kB
-160 B
9 B
react-tree
PersonaTree
142.381 kB
40.703 kB
142.222 kB
40.708 kB
-159 B
5 B
react-tree
Tree
141.693 kB
40.602 kB
141.534 kB
40.606 kB
-159 B
4 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
69.21 kB
20.174 kB
react-components
react-components: FluentProvider & webLightTheme
44.447 kB
14.59 kB
react-dialog
Dialog (including children components)
100.417 kB
30.097 kB
react-message-bar
MessageBar (all components)
24.825 kB
9.267 kB
react-portal-compat
PortalCompatProvider
8.39 kB
2.64 kB
react-timepicker-compat
TimePicker
108.525 kB
36.087 kB
🤖 This report was generated against e561700253aaaf2c6e17e5c70bf10c12c434bd96

Copy link

Pull request demo site: URL

@robertpenner robertpenner force-pushed the refactor/collapse-atoms branch from 0aea9d7 to 3608e82 Compare December 12, 2024 22:49
@robertpenner robertpenner force-pushed the refactor/collapse-atoms branch 6 times, most recently from 53ccc82 to fca343d Compare December 18, 2024 18:17
@robertpenner robertpenner force-pushed the refactor/collapse-atoms branch from fca343d to 6eabc48 Compare January 13, 2025 19:42
@robertpenner robertpenner force-pushed the refactor/collapse-atoms branch 2 times, most recently from 1c33b43 to 2fdcbee Compare January 13, 2025 20:03
@robertpenner robertpenner force-pushed the refactor/collapse-atoms branch from 2fdcbee to ede82f1 Compare January 13, 2025 20:09
@robertpenner robertpenner marked this pull request as ready for review January 13, 2025 20:10
@robertpenner robertpenner requested a review from a team as a code owner January 13, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Collapse] Streamline motion atom functions
2 participants