[Horizontal Bar Chart With Axis] Enable multiple legend selection #33484
+81
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
fabricteam
reviewed
Dec 18, 2024
| @@ -54,6 +54,7 @@ export interface IHorizontalBarChartWithAxisState extends IBasestate { | |||
| callOutAccessibilityData?: IAccessibilityProps; | |||
There was a problem hiding this comment.
🕵🏾♀️ visual regressions to review in the fluentuiv8 Visual Regression Report
Callout 6 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Callout.Right bottom edge.chromium.png | 3005 | Changed |
| Callout.Bottom Right Edge RTL.chromium.png | 1593 | Changed |
| Callout.Bottom auto edge.chromium.png | 2309 | Changed |
| Callout.No callout width specified.chromium.png | 2319 | Changed |
| Callout.Left center.chromium.png | 2616 | Changed |
| Callout.No beak.chromium.png | 2306 | Changed |
react-charting-AreaChart 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| react-charting-AreaChart.Custom Accessibility.chromium.png | 11 | Changed |
react-charting-LineChart 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| react-charting-LineChart.Gaps.chromium.png | 1 | Changed |
srmukher
force-pushed
the
users/srmukher/HBC_multi_legend
branch
from
403da6d to
5d4b991
Compare
AtishayMsft
reviewed
Dec 25, 2024
| if (this._isLegendSelected()) { | ||
| if (this._isSpecificLegendTitleSelected(currentLegend?.title!)) { | ||
| this.setState({ | ||
| isLegendSelected: false, |
AtishayMsft
reviewed
Dec 25, 2024
| @@ -780,11 +760,61 @@ export class HorizontalBarChartWithAxisBase extends React.Component< | |||
| focusZonePropsInHoverCard={this.props.focusZonePropsForLegendsInHoverCard} | |||
| overflowText={this.props.legendsOverflowText} | |||
| {...this.props.legendProps} | |||
| canSelectMultipleLegends={this.props.legendProps?.canSelectMultipleLegends} | |||
AtishayMsft
reviewed
Dec 25, 2024
| this.state.isLegendSelected === false || | ||
| (this.state.isLegendSelected && this.state.selectedLegendTitle === point.legend) | ||
| ) { | ||
| if (!this._isLegendSelected() || (this._isLegendSelected() && this._isSpecificLegendTitleSelected(point.legend!))) { |
AtishayMsft
reviewed
Dec 25, 2024
| shouldHighlight = this.state.selectedLegendTitle === point.legend; | ||
| if (this._isLegendHovered() || this._isLegendSelected()) { | ||
| shouldHighlight = | ||
| this._isSpecificLegendTitleSelected(point.legend!) || this._isSpecificLegendSelected(point.legend!); |
AtishayMsft
reviewed
Dec 25, 2024
| if (this.state.isLegendHovered || this.state.isLegendSelected) { | ||
| shouldHighlight = this.state.selectedLegendTitle === point.legend; | ||
| if (this._isLegendHovered() || this._isLegendSelected()) { | ||
| shouldHighlight = this._isSpecificLegendTitleSelected(point.legend!); |
|
Change file is missing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Horizontal Bar Chart With Axis] Enable multiple legend selection