fix: Remove deprecation warning from Callout's preventDismissOnResize, etc. #33493
+6
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behowell
added
Component: Callout
Fluent UI react (v8)
fabricteam
reviewed
Dec 19, 2024
| @@ -87,23 +87,23 @@ export interface ICalloutProps extends React.HTMLAttributes<HTMLDivElement>, Rea | |||
| isBeakVisible?: boolean; | |||
There was a problem hiding this comment.
🕵🏾♀️ visual regressions to review in the fluentuiv8 Visual Regression Report
Callout 3 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Callout.Top center.chromium.png | 2178 | Changed |
| Callout.Bottom Right Edge RTL.chromium.png | 1593 | Changed |
| Callout.Gap space 25.chromium.png | 2309 | Changed |
react-charting-HeatMapChart 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| react-charting-HeatMapChart.Basic.chromium.png | 376 | Changed |
📊 Bundle size report
Unchanged fixtures
|
|
Pull request demo site: URL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
v8 Callout's
preventDismissOnResize,preventDismissOnScroll, andpreventDismissOnFocusproperties were marked as deprecated 4+ years ago when thepreventDismissOnEventproperty was introduced, but the documentation isn't clear exactly how to replicate the behavior with the new API. Additionally,preventDismissOnFocusis not fully replicable usingpreventDismissOnEvent.New Behavior
Remove the
@deprecatedtag from Callout'spreventDismissOnResize,preventDismissOnScroll, andpreventDismissOnFocusproperties, given that we have no plans to actually remove these APIs from v8. They still work fine, and provider a simpler API for common use cases.Related Issue(s)